You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/15 18:22:20 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10325: fix(table-viz): value "undefined" for column.name
ktmud opened a new pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325
### SUMMARY
Bump table viz plugin to fix a bug: apache-superset/superset-ui#686
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See apache-superset/superset-ui#686
### TEST PLAN
Unit test in `superset-ui`.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325#issuecomment-658944383
Thanks @ktmud , I'll make sure this makes it into `rc2`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325#issuecomment-658933769
> I think you need to run `npm install`
Yes, but the package hasn't published. So was waiting for https://github.com/apache-superset/superset-ui/pull/686 to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325#issuecomment-658935694
@ktmud I'm assuming this is a 0.37 blocker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325#issuecomment-658935923
ah, my bad. i assumed this was ready for review. will stamp once CI passes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325#issuecomment-658940344
> @ktmud I'm assuming this is a 0.37 blocker?
@villebro yes, I would prefer this to be shipped with v0.37 as the fix is relatively simple and safe. We should be able to get it merged in a couple of hours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10325: fix(table-viz): value "undefined" for column.name
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10325:
URL: https://github.com/apache/incubator-superset/pull/10325#issuecomment-658932556
I think you need to run `npm install`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org