You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "sangeetha murali (JIRA)" <ji...@apache.org> on 2011/04/12 07:19:05 UTC

[jira] [Created] (WINK-343) Request.selectVariant() should process Accept-Charset headers in a case insensitive manner

Request.selectVariant() should process Accept-Charset headers in a case insensitive manner
------------------------------------------------------------------------------------------

                 Key: WINK-343
                 URL: https://issues.apache.org/jira/browse/WINK-343
             Project: Wink
          Issue Type: Bug
          Components: Server
            Reporter: sangeetha murali


The selectVariant should choose the correct variant, if the consumer gives the character set in any case (upper, lower, mixed)

"HTTP character sets are identified by case-insensitive tokens." as per RFC [1]

[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.4 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (WINK-343) Request.selectVariant() should process Accept-Charset headers in a case insensitive manner

Posted by "sangeetha murali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sangeetha murali closed WINK-343.
---------------------------------

    Resolution: Invalid

> Request.selectVariant() should process Accept-Charset headers in a case insensitive manner
> ------------------------------------------------------------------------------------------
>
>                 Key: WINK-343
>                 URL: https://issues.apache.org/jira/browse/WINK-343
>             Project: Wink
>          Issue Type: Bug
>          Components: Server
>            Reporter: sangeetha murali
>
> The selectVariant should choose the correct variant, if the consumer gives the character set in any case (upper, lower, mixed)
> "HTTP character sets are identified by case-insensitive tokens." as per RFC [1]
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.4 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WINK-343) Request.selectVariant() should process Accept-Charset headers in a case insensitive manner

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018876#comment-13018876 ] 

Bryant Luk commented on WINK-343:
---------------------------------

Hmm I think the code currently does ignore case sensitivity.

>From http://svn.apache.org/repos/asf/incubator/wink/trunk/wink-server/src/main/java/org/apache/wink/server/internal/contexts/RequestImpl.java 
around line 449:

{code}
if (charset.isWildcard() || vCharset.equalsIgnoreCase(charset.charset))
{code}

Can you give an example of what request Accept-* headers the client is sending and what you're passing into selectVariant()? Thanks.

> Request.selectVariant() should process Accept-Charset headers in a case insensitive manner
> ------------------------------------------------------------------------------------------
>
>                 Key: WINK-343
>                 URL: https://issues.apache.org/jira/browse/WINK-343
>             Project: Wink
>          Issue Type: Bug
>          Components: Server
>            Reporter: sangeetha murali
>
> The selectVariant should choose the correct variant, if the consumer gives the character set in any case (upper, lower, mixed)
> "HTTP character sets are identified by case-insensitive tokens." as per RFC [1]
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.4 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WINK-343) Request.selectVariant() should process Accept-Charset headers in a case insensitive manner

Posted by "sangeetha murali (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019260#comment-13019260 ] 

sangeetha murali commented on WINK-343:
---------------------------------------

I found that this bug was on another implementation of Request, I am closing this bug since it is invalid here. Thanks for the pointers.

> Request.selectVariant() should process Accept-Charset headers in a case insensitive manner
> ------------------------------------------------------------------------------------------
>
>                 Key: WINK-343
>                 URL: https://issues.apache.org/jira/browse/WINK-343
>             Project: Wink
>          Issue Type: Bug
>          Components: Server
>            Reporter: sangeetha murali
>
> The selectVariant should choose the correct variant, if the consumer gives the character set in any case (upper, lower, mixed)
> "HTTP character sets are identified by case-insensitive tokens." as per RFC [1]
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.4 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira