You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/19 20:46:10 UTC

[GitHub] [hbase] arshadmohammad opened a new pull request #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

arshadmohammad opened a new pull request #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312
 
 
   HBASE-24019: Correct exception messages for table null and namespace unavailable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] virajjasani commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-602022964
 
 
   @arshadmohammad could you please raise PR for branch-2 also? Then we can check-in to branch-2, 2.3 and 2.2.
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] virajjasani merged pull request #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] arshadmohammad commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-601867307
 
 
   Change is applicable to branch-2 code. This same change can be applied to branch-2 as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] arshadmohammad commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-601856311
 
 
   yes, this problem is not there in master code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] virajjasani commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-602023423
 
 
   I think it's fine, no need to raise another PR. QA results here are good. Good to merge.
   @HorizonNet let me commit this to all branch-2's? Should be fine?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-601431737
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ branch-2.2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 15s |  branch-2.2 passed  |
   | +1 :green_heart: |  compile  |   0m 25s |  branch-2.2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  branch-2.2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m  4s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  branch-2.2 passed  |
   | +0 :ok: |  spotbugs  |   0m 51s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   0m 49s |  branch-2.2 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 10s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 45s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   1m 17s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   3m 59s |  hbase-rsgroup in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 16s |  The patch does not generate ASF License warnings.  |
   |  |   |  50m  2s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1312/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1312 |
   | JIRA Issue | HBASE-24019 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux f664db58db33 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1312/out/precommit/personality/provided.sh |
   | git revision | branch-2.2 / 3263c2005e |
   | Default Java | 1.8.0_181 |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1312/1/testReport/ |
   | Max. process+thread count | 4101 (vs. ulimit of 10000) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1312/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] HorizonNet commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
HorizonNet commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-601933604
 
 
   Then it should go to branch-2 first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1312: HBASE-24019: Correct exception messages for table null and namespace unavailable.
URL: https://github.com/apache/hbase/pull/1312#issuecomment-601881719
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ branch-2.2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 18s |  branch-2.2 passed  |
   | +1 :green_heart: |  compile  |   0m 27s |  branch-2.2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  branch-2.2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m  4s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  branch-2.2 passed  |
   | +0 :ok: |  spotbugs  |   0m 47s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   0m 44s |  branch-2.2 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 50s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 26s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedjars  |   4m  4s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  20m 10s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   0m 50s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   3m 11s |  hbase-rsgroup in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 13s |  The patch does not generate ASF License warnings.  |
   |  |   |  52m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1312/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1312 |
   | JIRA Issue | HBASE-24019 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux d91108d12bfa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1312/out/precommit/personality/provided.sh |
   | git revision | branch-2.2 / fd62d2d175 |
   | Default Java | 1.8.0_181 |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1312/2/testReport/ |
   | Max. process+thread count | 4109 (vs. ulimit of 10000) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1312/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services