You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/13 21:46:09 UTC
[GitHub] jmeter pull request #359: Added finals to fields where possible
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/359
Added finals to fields where possible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter final
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/359.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #359
----
commit f46d1c4d57d67a9fb137ba981fe9ef6e73d5ecaa
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-13T20:31:34Z
added final
----
---
[GitHub] jmeter issue #359: Added finals to fields where possible
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/359
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=h1) Report
> Merging [#359](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/359/graphs/tree.svg?width=650&height=150&token=6Q7CI1wFSh&src=pr)](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #359 +/- ##
=========================================
Coverage 58.19% 58.19%
Complexity 10210 10210
=========================================
Files 1161 1161
Lines 74189 74189
Branches 7322 7322
=========================================
Hits 43174 43174
Misses 28517 28517
Partials 2498 2498
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rotocol/jdbc/config/DataSourceElementBeanInfo.java](https://codecov.io/gh/apache/jmeter/pull/359/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2pkYmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvamRiYy9jb25maWcvRGF0YVNvdXJjZUVsZW1lbnRCZWFuSW5mby5qYXZh) | `90.14% <100%> (ø)` | `5 <0> (ø)` | :arrow_down: |
| [...jmeter/protocol/http/control/HC4CookieHandler.java](https://codecov.io/gh/apache/jmeter/pull/359/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL0hDNENvb2tpZUhhbmRsZXIuamF2YQ==) | `86.44% <100%> (ø)` | `21 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=footer). Last update [427907f...cc5154f](https://codecov.io/gh/apache/jmeter/pull/359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter pull request #359: Added finals to fields where possible
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/359
---