You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/18 22:56:15 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #6995: [HUDI-3900] Closing resources in TestHoodieLogRecord
nsivabalan opened a new pull request, #6995:
URL: https://github.com/apache/hudi/pull/6995
### Change Logs
Closing writers and scanners in TestHoodieLogFormat.
### Impact
n/a
### Risk level (write none, low medium or high below)
low. stablizes CI.
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #6995: [HUDI-3900] Closing resources in TestHoodieLogRecord
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6995:
URL: https://github.com/apache/hudi/pull/6995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6995: [HUDI-3900] Closing resources in TestHoodieLogRecord
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6995:
URL: https://github.com/apache/hudi/pull/6995#issuecomment-1283143652
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "381473cd08d4ac0c7c11027b1514b0e906c11819",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12317",
"triggerID" : "381473cd08d4ac0c7c11027b1514b0e906c11819",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 381473cd08d4ac0c7c11027b1514b0e906c11819 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12317)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6995: [HUDI-3900] Closing resources in TestHoodieLogRecord
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6995:
URL: https://github.com/apache/hudi/pull/6995#issuecomment-1283374438
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "381473cd08d4ac0c7c11027b1514b0e906c11819",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12317",
"triggerID" : "381473cd08d4ac0c7c11027b1514b0e906c11819",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 381473cd08d4ac0c7c11027b1514b0e906c11819 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12317)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6995: [HUDI-3900] Closing resources in TestHoodieLogRecord
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6995:
URL: https://github.com/apache/hudi/pull/6995#issuecomment-1283138958
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "381473cd08d4ac0c7c11027b1514b0e906c11819",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "381473cd08d4ac0c7c11027b1514b0e906c11819",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 381473cd08d4ac0c7c11027b1514b0e906c11819 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6995: [HUDI-3900] Closing resources in TestHoodieLogRecord
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6995:
URL: https://github.com/apache/hudi/pull/6995#discussion_r998929769
##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -155,6 +155,7 @@ public void testEmptyLog() throws IOException {
assertEquals(0, writer.getCurrentSize(), "Just created this log, size should be 0");
assertTrue(writer.getLogFile().getFileName().startsWith("."), "Check all log files should start with a .");
assertEquals(1, writer.getLogFile().getLogVersion(), "Version should be 1 for new log created");
+ writer.close();
Review Comment:
@nsivabalan for the future reference: it's easier to manage and more predictable to use try-with-resources statement:
```
try (Closeable c = ...) {
// Will be closed automatically even in the presence of exceptions
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org