You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/21 09:44:27 UTC

[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled

eolivelli commented on code in PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#discussion_r902401883


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java:
##########
@@ -359,5 +359,9 @@ public void quarantineBookie(BookieId bookie) {
         }
     }
 
-
+    public void releaseAllQuarantinedBookies(){
+        if (quarantinedBookies.size() > 0){

Review Comment:
   why do you need this condition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org