[GitHub] [flink] mas-chen commented on a diff in pull request #22291: [FLINK-31632] Fix maxAllowedWatermark arithmetic overflow when the source is idle

["mas-chen (via GitHub)" <gi...@apache.org>]

mas-chen commented on code in PR #22291:
URL: https://github.com/apache/flink/pull/22291#discussion_r1159300038


##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorAlignmentTest.java:
##########
@@ -167,6 +167,9 @@ public void testWatermarkAlignmentWithIdleness() throws Exception {
             assertThat(operator.emitNext(actualOutput), is(DataInputStatus.NOTHING_AVAILABLE));
             context.getTimeService().advance(1);
             assertLatestReportedWatermarkEvent(context, Long.MAX_VALUE);
+            // receive Long.MAX_VALUE as WatermarkAlignmentEvent

Review Comment:
   Oh, I see. Does it make sense to call operator.handleOperatorEvent(new WatermarkAlignmentEvent(...)) after every `assertLatestReportedWatermarkEvent` (line 162)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org