You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Valencia Edna Serrao (Code Review)" <ge...@cloudera.org> on 2017/10/23 16:05:27 UTC
[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac
Valencia Edna Serrao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8356
Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
......................................................................
Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
Change-Id: I14768c522641212ef44bb0293c1914636764248f
---
M init-compiler.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/56/8356/1
--
To view, visit http://gerrit.cloudera.org:8080/8356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14768c522641212ef44bb0293c1914636764248f
Gerrit-Change-Number: 8356
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8356 )
Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14768c522641212ef44bb0293c1914636764248f
Gerrit-Change-Number: 8356
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Oct 2017 16:13:09 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8356 )
Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
......................................................................
Patch Set 1:
Thanks Valencia!
--
To view, visit http://gerrit.cloudera.org:8080/8356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14768c522641212ef44bb0293c1914636764248f
Gerrit-Change-Number: 8356
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Oct 2017 16:15:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8356 )
Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
......................................................................
Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
Change-Id: I14768c522641212ef44bb0293c1914636764248f
---
M init-compiler.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/8356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I14768c522641212ef44bb0293c1914636764248f
Gerrit-Change-Number: 8356
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8356 )
Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
......................................................................
Patch Set 1: Verified+1
I don't have a Mac to verify on, but did a quick test build of gperftools on linux to make sure nothing broke (e.g. syntax errors in the shell script).
--
To view, visit http://gerrit.cloudera.org:8080/8356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14768c522641212ef44bb0293c1914636764248f
Gerrit-Change-Number: 8356
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Oct 2017 16:15:26 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Fixes github Issues#23 "ARCH FLAGS: unbound variable" for mac
Posted by "Valencia Edna Serrao (Code Review)" <ge...@cloudera.org>.
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8356 )
Change subject: Fixes github Issues#23 "ARCH_FLAGS: unbound variable" for mac
......................................................................
Patch Set 1:
> Thanks Valencia!
Thanks, Tim!
--
To view, visit http://gerrit.cloudera.org:8080/8356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14768c522641212ef44bb0293c1914636764248f
Gerrit-Change-Number: 8356
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Tue, 24 Oct 2017 03:39:43 +0000
Gerrit-HasComments: No