You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/12 07:30:15 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #6342: Python: Introduce SchemaVisitorPerPrimitiveType

Fokko commented on code in PR #6342:
URL: https://github.com/apache/iceberg/pull/6342#discussion_r1045479465


##########
python/pyiceberg/schema.py:
##########
@@ -317,6 +331,97 @@ def primitive(self, primitive: PrimitiveType) -> T:
         """Visit a PrimitiveType"""
 
 
+class SchemaVisitorPerPrimitiveType(SchemaVisitor[T], ABC):

Review Comment:
   I think it is fair to have both of them. The `SchemaVisitor` is used for building the positional arguments for example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org