You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/05/10 04:27:44 UTC

[GitHub] [commons-fileupload] arturobernalg opened a new pull request #88: FILEUPLOAD-336 - WhitespaceAround

arturobernalg opened a new pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88


   '+' is not preceded with whitespace. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] coveralls commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836153815


   
   [![Coverage Status](https://coveralls.io/builds/39509750/badge)](https://coveralls.io/builds/39509750)
   
   Coverage remained the same at 78.341% when pulling **c7080af4736e0b922e762320f3286888ac31814a on arturobernalg:feature/FILEUPLOAD-336** into **5352ef0a1c914473de0820fc962cb81d8c5b6167 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] arturobernalg commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-841809925


   > Resolving Checkstyle issues is helpful, of course. Thanks!
   > 
   > But, as we now have conflicts: Could you, please, rebase?
   
   HI @jochenw 
   there is still a lot of work regarding checkstyle. I can work on fix those error while waiting for ticker response FILEUPLOAD-275  
   TY 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] coveralls edited a comment on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836153815






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] arturobernalg commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-841809925


   > Resolving Checkstyle issues is helpful, of course. Thanks!
   > 
   > But, as we now have conflicts: Could you, please, rebase?
   
   HI @jochenw 
   there is still a lot of work regarding checkstyle. I can work on fix those error while waiting for ticker response FILEUPLOAD-275  
   TY 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] coveralls edited a comment on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836153815


   
   [![Coverage Status](https://coveralls.io/builds/39720816/badge)](https://coveralls.io/builds/39720816)
   
   Coverage remained the same at 78.341% when pulling **b9b5ca25ecdc717c64a273954efee3dac33e4184 on arturobernalg:feature/FILEUPLOAD-336** into **09d63053a3d295462e645feca9a67668cd19518d on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] arturobernalg commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836299858


   > Honestly, I don't see any value in this change? What purpose does it serve?
   
   technically speaking, for nothing. It's just for solve all the checkstyle issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] coveralls edited a comment on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836153815


   
   [![Coverage Status](https://coveralls.io/builds/39721477/badge)](https://coveralls.io/builds/39721477)
   
   Coverage remained the same at 78.278% when pulling **b5c9fd79506f237da028c274eef2d9f9bb3d41bf on arturobernalg:feature/FILEUPLOAD-336** into **5b5e8a6a03960eab3868fc5e7026d5a727e9bb76 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw merged pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
jochenw merged pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836292219


   Honestly, I don't see any value in this change? What purpose does it serve?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-841805649


   Resolving Checkstyle issues is helpful, of course. Thanks!
   
   But, as we now have conflicts: Could you, please, rebase?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw merged pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
jochenw merged pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-841805649


   Resolving Checkstyle issues is helpful, of course. Thanks!
   
   But, as we now have conflicts: Could you, please, rebase?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org