You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lo...@apache.org on 2022/04/13 16:07:33 UTC
[beam] branch master updated: Fix a couple style issues (#17361)
This is an automated email from the ASF dual-hosted git repository.
lostluck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 4b47e3cb352 Fix a couple style issues (#17361)
4b47e3cb352 is described below
commit 4b47e3cb352d7af9fd1e2ec71bfdeb71a01fc8f9
Author: Danny McCormick <da...@google.com>
AuthorDate: Wed Apr 13 12:07:27 2022 -0400
Fix a couple style issues (#17361)
---
sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go | 4 ++--
sdks/go/pkg/beam/core/runtime/xlangx/registry.go | 7 ++++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go b/sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go
index 2c0168a5afe..12488638fab 100644
--- a/sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go
+++ b/sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go
@@ -69,8 +69,8 @@ func SetDefaultRepositoryURL(repoURL string) error {
return defaultJarGetter.setRepositoryURL(repoURL)
}
-func buildJarName(artifactId, version string) string {
- return fmt.Sprintf("%s-%s.jar", artifactId, version)
+func buildJarName(artifactID, version string) string {
+ return fmt.Sprintf("%s-%s.jar", artifactID, version)
}
func getMavenJar(artifactID, groupID, version string) string {
diff --git a/sdks/go/pkg/beam/core/runtime/xlangx/registry.go b/sdks/go/pkg/beam/core/runtime/xlangx/registry.go
index efb3477d6b1..db6f86627ab 100644
--- a/sdks/go/pkg/beam/core/runtime/xlangx/registry.go
+++ b/sdks/go/pkg/beam/core/runtime/xlangx/registry.go
@@ -267,12 +267,13 @@ func Require(expansionAddr string) string {
return hardOverrideNamespace + Separator + expansionAddr
}
-type expansionServiceOption func(*string)
+// ExpansionServiceOption provides an option for xlangx.UseAutomatedJavaExpansionService()
+type ExpansionServiceOption func(*string)
// AddClasspaths is an expansion service option for xlangx.UseAutomatedExpansionService
// that accepts a classpaths slice and creates a tagged expansion address string
// suffixed with classpath separator and classpaths provided.
-func AddClasspaths(classpaths []string) expansionServiceOption {
+func AddClasspaths(classpaths []string) ExpansionServiceOption {
return func(expansionAddress *string) {
*expansionAddress += ClasspathSeparator + strings.Join(classpaths, " ")
}
@@ -285,7 +286,7 @@ func AddClasspaths(classpaths []string) expansionServiceOption {
// Intended for use by cross language wrappers to permit spinning
// up an expansion service for a user if no expansion service address
// is provided.
-func UseAutomatedJavaExpansionService(gradleTarget string, opts ...expansionServiceOption) string {
+func UseAutomatedJavaExpansionService(gradleTarget string, opts ...ExpansionServiceOption) string {
expansionAddress := autoJavaNamespace + Separator + gradleTarget
for _, opt := range opts {