[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4017: rpmsg_socket: fix rpmsg_socket_device_destroy() multi-access

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #4017:
URL: https://github.com/apache/incubator-nuttx/pull/4017#discussion_r663397544



##########
File path: net/rpmsg/rpmsg_sockif.c
##########
@@ -386,7 +386,14 @@ static int rpmsg_socket_ept_cb(FAR struct rpmsg_endpoint *ept,
 static inline void rpmsg_socket_destroy_ept(
                     FAR struct rpmsg_socket_conn_s *conn)
 {
-  if (conn && conn->ept.rdev)
+  if (!conn)

Review comment:
       @davids5 there are many places which check the pointer by if (p) or if (!p), so please send the suggestion to the mail list and get approved before we enforce your personal code style rule.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org