You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/16 11:25:41 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

bartekkuncer opened a new pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034


   ## Description ##
   This change changes *_mkldnn* test and build scenarios names to *_onednn*.
   
   ## Checklist ##
   ### Changes ###
   - [ ] Change scenarios names
   - [ ] Change names of created in Jenkins files instances of mxnet using onednn
   - [ ] Change return strings from scenarios
   - [ ] Change workspace names in scenarios 
   
   ## Comments ##
   Work in progress.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595768651



##########
File path: ci/jenkins/Jenkinsfile_unix_cpu
##########
@@ -37,17 +37,17 @@ core_logic: {
     custom_steps.compile_unix_cpu_openblas('cpu'),
     custom_steps.compile_unix_openblas_debug_cpu('cpu_debug'),
     custom_steps.compile_unix_mkl_cpu('cpu_mkl'),
-    custom_steps.compile_unix_mkldnn_cpu('mkldnn_cpu'),
-    custom_steps.compile_unix_mkldnn_mkl_cpu('mkldnn_mkl_cpu'),
+    custom_steps.compile_unix_onednn_cpu('mkldnn_cpu'),

Review comment:
       It is already listed in proposed changes under "Change names of created in Jenkins files instances of mxnet using onednn".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-800868887


   @mxnet-bot run ci [unix-cpu,windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595835147



##########
File path: ci/dev_menu.py
##########
@@ -148,7 +148,7 @@ def provision_virtualenv(venv_path=DEFAULT_PYENV):
     ]),
     ('[Docker] Python3 CPU Intel MKLDNN unittests',
     [
-        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_mkldnn",
+        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_onednn",
         "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh unittest_ubuntu_python3_cpu",
     ]),
     ('[Docker] Python3 ARMv7 unittests (QEMU)',

Review comment:
       @leezu I saw that some of the functions called here are not present in ci/docker/runtime_functions.sh file. Is there a separate file for CI stored outside of this repository or maybe these names should be updated?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-801177980


   @mxnet-bot run ci [centos-cpu,windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-804005936


   Jenkins CI successfully triggered : [windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer edited a comment on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer edited a comment on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-801270041


   @szha @leezu Please help with the merge :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-800177430


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, miscellaneous, website, windows-gpu, windows-cpu, clang, sanity, edge, centos-cpu, centos-gpu, unix-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595835147



##########
File path: ci/dev_menu.py
##########
@@ -148,7 +148,7 @@ def provision_virtualenv(venv_path=DEFAULT_PYENV):
     ]),
     ('[Docker] Python3 CPU Intel MKLDNN unittests',
     [
-        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_mkldnn",
+        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_onednn",
         "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh unittest_ubuntu_python3_cpu",
     ]),
     ('[Docker] Python3 ARMv7 unittests (QEMU)',

Review comment:
       @szha @leezu I saw that some of the functions called here are not present in ci/docker/runtime_functions.sh file. Is there a separate file for CI stored outside of this repository or maybe these names should be updated? If so I will do this in separate PR as this one regards switching names from *mkldnn* to *onednn*.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-803912721


   @szha @leezu Is something blocking the merge of this PR? If so can I help with resolving the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595835147



##########
File path: ci/dev_menu.py
##########
@@ -148,7 +148,7 @@ def provision_virtualenv(venv_path=DEFAULT_PYENV):
     ]),
     ('[Docker] Python3 CPU Intel MKLDNN unittests',
     [
-        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_mkldnn",
+        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_onednn",
         "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh unittest_ubuntu_python3_cpu",
     ]),
     ('[Docker] Python3 ARMv7 unittests (QEMU)',

Review comment:
       @szha @leezu I saw that some of the functions called here are not present in ci/docker/runtime_functions.sh file. Is there a separate file for CI stored outside of this repository or maybe these names should be updated?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on a change in pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r597067808



##########
File path: ci/dev_menu.py
##########
@@ -148,7 +148,7 @@ def provision_virtualenv(venv_path=DEFAULT_PYENV):
     ]),
     ('[Docker] Python3 CPU Intel MKLDNN unittests',
     [
-        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_mkldnn",
+        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_onednn",
         "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh unittest_ubuntu_python3_cpu",
     ]),
     ('[Docker] Python3 ARMv7 unittests (QEMU)',

Review comment:
       This file is outdated and needs to be updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-801270041


   @leezu Please help with the merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-802971064


   @szha @leezu As I have resolved the merge problem please help with the merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-805857793


   > Is there something blocking this PR?
   
   No :) Sorry for the delay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-804005905


   @mxnet-bot run ci [windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-800460957


   Jenkins CI successfully triggered : [windows-cpu, unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-800868942


   Jenkins CI successfully triggered : [unix-cpu, windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595767658



##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -161,55 +161,55 @@ def compile_unix_mkl_cpu(lib_name) {
     }]
 }
 
-def compile_unix_mkldnn_cpu(lib_name) {
+def compile_unix_onednn_cpu(lib_name) {
     return ['CPU: MKLDNN': {
       node(NODE_LINUX_CPU) {
         ws('workspace/build-mkldnn-cpu') {

Review comment:
       It is already listed in proposed changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-805778919


   @szha Is there something blocking this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-801178025


   Jenkins CI successfully triggered : [centos-cpu, windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer edited a comment on pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer edited a comment on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-801270041


   @szha @leezu Please help with the merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595491631



##########
File path: ci/jenkins/Jenkinsfile_unix_cpu
##########
@@ -37,17 +37,17 @@ core_logic: {
     custom_steps.compile_unix_cpu_openblas('cpu'),
     custom_steps.compile_unix_openblas_debug_cpu('cpu_debug'),
     custom_steps.compile_unix_mkl_cpu('cpu_mkl'),
-    custom_steps.compile_unix_mkldnn_cpu('mkldnn_cpu'),
-    custom_steps.compile_unix_mkldnn_mkl_cpu('mkldnn_mkl_cpu'),
+    custom_steps.compile_unix_onednn_cpu('mkldnn_cpu'),

Review comment:
       Yes. The only requirement is to be consistent. (Ie. use the same name for the compile as well as the test job)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595767658



##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -161,55 +161,55 @@ def compile_unix_mkl_cpu(lib_name) {
     }]
 }
 
-def compile_unix_mkldnn_cpu(lib_name) {
+def compile_unix_onednn_cpu(lib_name) {
     return ['CPU: MKLDNN': {
       node(NODE_LINUX_CPU) {
         ws('workspace/build-mkldnn-cpu') {

Review comment:
       It is already listed is proposed changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#issuecomment-800460896


   @mxnet-bot run ci [unix-cpu,windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20034: [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn*

Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595481862



##########
File path: ci/jenkins/Jenkinsfile_unix_cpu
##########
@@ -37,17 +37,17 @@ core_logic: {
     custom_steps.compile_unix_cpu_openblas('cpu'),
     custom_steps.compile_unix_openblas_debug_cpu('cpu_debug'),
     custom_steps.compile_unix_mkl_cpu('cpu_mkl'),
-    custom_steps.compile_unix_mkldnn_cpu('mkldnn_cpu'),
-    custom_steps.compile_unix_mkldnn_mkl_cpu('mkldnn_mkl_cpu'),
+    custom_steps.compile_unix_onednn_cpu('mkldnn_cpu'),

Review comment:
       for me it seems that "lib_name" parameter also could be easily changed to onednn_cpu

##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -161,55 +161,55 @@ def compile_unix_mkl_cpu(lib_name) {
     }]
 }
 
-def compile_unix_mkldnn_cpu(lib_name) {
+def compile_unix_onednn_cpu(lib_name) {
     return ['CPU: MKLDNN': {
       node(NODE_LINUX_CPU) {
         ws('workspace/build-mkldnn-cpu') {

Review comment:
       Please consider renaming also workspace names




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org