You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "SIDDHARTH TEOTIA (JIRA)" <ji...@apache.org> on 2017/09/05 20:34:00 UTC
[jira] [Updated] (ARROW-1467) Fix reset() and allocateNew() in
Nullable Value Vectors template
[ https://issues.apache.org/jira/browse/ARROW-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
SIDDHARTH TEOTIA updated ARROW-1467:
------------------------------------
Description:
(1)
allocateNew() in NullableValueVectors allocates extra memory for the validity vector of fixed-width vectors. Instead of doing bits.allocateNew(valueCount + 1), we should simply do bits.allocateNew(valueCount).
AFAIK, the only case where we need an additional valueCount is for the offsetVector and we already do that. Additional valueCount for the validity vector is not needed.
(2)
reset() method should call reset() on the underlying value vector as well to re-initialize the state (allocation monitor, reader index etc) and zero out the buffers. Right now we just reset the validity vector.
was:
(1)
allocateNew() in NullableValueVectors allocates extra memory for the validity vector of fixed-width vectors. Instead of doing bits.allocateNew(valueCount + 1), we should simply do bits.allocateNew(valueCount).
AFAIK, the only case where we need an additional valueCount is for the offsetVector and we already do that. Additional valueCount for the validity vector is not needed.
(2)
reset() method should call reset() on the underlying value vector to re-initialize the state (allocation monitor, reader index etc) and zero out the buffers. Right now we just reset the validity vector.
> Fix reset() and allocateNew() in Nullable Value Vectors template
> ----------------------------------------------------------------
>
> Key: ARROW-1467
> URL: https://issues.apache.org/jira/browse/ARROW-1467
> Project: Apache Arrow
> Issue Type: Bug
> Reporter: SIDDHARTH TEOTIA
> Assignee: SIDDHARTH TEOTIA
>
> (1)
> allocateNew() in NullableValueVectors allocates extra memory for the validity vector of fixed-width vectors. Instead of doing bits.allocateNew(valueCount + 1), we should simply do bits.allocateNew(valueCount).
> AFAIK, the only case where we need an additional valueCount is for the offsetVector and we already do that. Additional valueCount for the validity vector is not needed.
> (2)
> reset() method should call reset() on the underlying value vector as well to re-initialize the state (allocation monitor, reader index etc) and zero out the buffers. Right now we just reset the validity vector.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)