[jira] [Commented] (KAFKA-7779) Avoid unnecessary loop iteration in leastLoadedNode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731870#comment-16731870 ] 

ASF GitHub Bot commented on KAFKA-7779:
---------------------------------------

huxihx commented on pull request #6081: KAFKA-7779: Avoid unnecessary loop iteration in leastLoadedNode
URL: https://github.com/apache/kafka/pull/6081
 
 
   https://issues.apache.org/jira/browse/KAFKA-7779
   
   In NetworkClient.leastLoadedNode, it invokes `isReady` to  check if an established connection exists for the given node. `isReady` checks whether metadata needs to be updated also which wants to make metadata request first priority. However, if the to-be-sent request is metadata request, then we do not have to check this otherwise the loop in `leastLoadedNode` will do a complete iteration until the final node is selected. That's not performance efficient for a large cluster.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Avoid unnecessary loop iteration in leastLoadedNode
> ---------------------------------------------------
>
>                 Key: KAFKA-7779
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7779
>             Project: Kafka
>          Issue Type: Improvement
>          Components: network
>    Affects Versions: 2.1.0
>            Reporter: huxihx
>            Assignee: huxihx
>            Priority: Minor
>
> In NetworkClient.leastLoadedNode, it invokes `isReady` to  check if an established connection exists for the given node. `isReady` checks whether metadata needs to be updated also which wants to make metadata request first priority. However, if the to-be-sent request is metadata request, then we do not have to check this otherwise the loop in `leastLoadedNode` will do a complete iteration until the final node is selected. That's not performance efficient for a large cluster.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)