You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/02 21:29:21 UTC

[GitHub] [hadoop] steveloughran commented on issue #1186: HADOOP-16472. findbugs warning on LocalMetadataStore.ttlTimeProvider sync

steveloughran commented on issue #1186: HADOOP-16472. findbugs warning on LocalMetadataStore.ttlTimeProvider sync
URL: https://github.com/apache/hadoop/pull/1186#issuecomment-517849769
 
 
   That's the same sync problem; I'm going to merge this one in.
   
   I don't care about a line length of 81; we are allowed to ignore that 81 char width rule if we think it would be worse for the code visibility to chop things...the last time there was a vote on it the consensus was "not widen because it makes side-by-side review harder". Once the move to github reviews is complete, we can explore that decision again. After all, monitors have got bigger...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org