You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/26 17:27:46 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #3955: Use Arc and Arc<[Field]> in DataType and Schema
tustvold opened a new issue, #3955:
URL: https://github.com/apache/arrow-rs/issues/3955
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
Currently `DataType` and `Schema` use `Box<Field>` and `Vec<Field>` for nested types such as `StructArray`, etc... This has a couple of drawbacks:
* `Field` is not cheap to clone, involving cloning `String`, `DataType`, and potentially `HashMap`
* `DataType` comparison cannot make use of cheap pointer comparison
* Converting between `DataType::Struct` and `Schema` is unnecessarily expensive
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
`DataType` should be updated to use `Arc<Field>` instead of `Box<Field>` and `Arc<[Field]>` instead of `Vec<Field>`.
Similarly `Schema::new` should be updated to accept `impl Into<Arc<[Field]>>`
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #3955: Reduce Cloning of Field
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #3955:
URL: https://github.com/apache/arrow-rs/issues/3955#issuecomment-1486800732
I believe @tustvold is working on this, so assigning to him
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #3955: Reduce Cloning of Field
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3955:
URL: https://github.com/apache/arrow-rs/issues/3955#issuecomment-1484181441
This would be a potentially breaking change as https://github.com/apache/arrow-rs/pull/2239 made Schema's fields public...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #3955: Reduce Cloning of Field
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #3955: Reduce Cloning of Field
URL: https://github.com/apache/arrow-rs/issues/3955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #3955: Reduce Cloning of Field
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3955:
URL: https://github.com/apache/arrow-rs/issues/3955#issuecomment-1500235795
`label_issue.py` automatically added labels {'arrow-flight'} from #3965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #3955: Reduce Cloning of Field
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3955:
URL: https://github.com/apache/arrow-rs/issues/3955#issuecomment-1500235778
`label_issue.py` automatically added labels {'parquet'} from #3956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org