[GitHub] [airflow] XD-DENG commented on a diff in pull request #29299: [KubernetesExecutor] make the number of log lines to read from the worker pod configurable

["XD-DENG (via GitHub)" <gi...@apache.org>]

XD-DENG commented on code in PR #29299:
URL: https://github.com/apache/airflow/pull/29299#discussion_r1103720253


##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -1313,6 +1313,9 @@ worker_pods_queued_check_interval = 60
 # You may want this higher if you have a very large cluster and/or use ``multi_namespace_mode``.
 worker_pods_pending_timeout_batch_size = 100
 
+# The number of lines (from the end) of the logs to read from the worker pod's base container.
+read_log_lines = 100

Review Comment:
   Thanks @dstandish . Renamed as suggested.
   
   I fully understand the concern about adding another config param, but I still find this necessary. `100` lines seems reasonable for most cases, but when user want to have more flexibility, e.g. debugging their jobs, more log lines will be needed (this happens to me often in real works).
   
   Comparing with different methods, like the one you shared above (class constant and monkey patch in local settings), I still find adding it as a config param is better.
   
   Please let me know if these clarify, or should you have any other concern. Thanks a lot!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org