You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Marta Kuczora via Review Board <no...@reviews.apache.org> on 2018/01/26 13:03:52 UTC
Review Request 65349: HIVE-18544: Create tests to cover methods for
appending Partitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/
-----------------------------------------------------------
Review request for hive, Peter Vary and Adam Szita.
Bugs: HIVE-18544
https://issues.apache.org/jira/browse/HIVE-18544
Repository: hive-git
Description
-------
The following methods of IMetaStoreClient are covered by this test.
- Partition appendPartition(String, String, List<String>)
- Partition appendPartition(String, String, String)
The test covers not just the happy pathes, but the edge cases as well.
Diffs
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65349/diff/1/
Testing
-------
Run the tests
Thanks,
Marta Kuczora
Re: Review Request 65349: HIVE-18544: Create tests to cover methods
for appending Partitions
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/#review196428
-----------------------------------------------------------
Ship it!
Ship It!
- Adam Szita
On Jan. 29, 2018, 12:49 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65349/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:49 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18544
> https://issues.apache.org/jira/browse/HIVE-18544
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - Partition appendPartition(String, String, List<String>)
> - Partition appendPartition(String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65349/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65349: HIVE-18544: Create tests to cover methods
for appending Partitions
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 12:49 p.m.)
Review request for hive, Peter Vary and Adam Szita.
Changes
-------
Address review findings
Bugs: HIVE-18544
https://issues.apache.org/jira/browse/HIVE-18544
Repository: hive-git
Description
-------
The following methods of IMetaStoreClient are covered by this test.
- Partition appendPartition(String, String, List<String>)
- Partition appendPartition(String, String, String)
The test covers not just the happy pathes, but the edge cases as well.
Diffs (updated)
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65349/diff/2/
Changes: https://reviews.apache.org/r/65349/diff/1-2/
Testing
-------
Run the tests
Thanks,
Marta Kuczora
Re: Review Request 65349: HIVE-18544: Create tests to cover methods
for appending Partitions
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
> On Jan. 26, 2018, 1:53 p.m., Peter Vary wrote:
> > Ship It!
Thanks a lot Peter for the review.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/#review196338
-----------------------------------------------------------
On Jan. 29, 2018, 12:49 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65349/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:49 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18544
> https://issues.apache.org/jira/browse/HIVE-18544
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - Partition appendPartition(String, String, List<String>)
> - Partition appendPartition(String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65349/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65349: HIVE-18544: Create tests to cover methods
for appending Partitions
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/#review196338
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On Jan. 26, 2018, 1:03 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65349/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 1:03 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18544
> https://issues.apache.org/jira/browse/HIVE-18544
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - Partition appendPartition(String, String, List<String>)
> - Partition appendPartition(String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65349/diff/1/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65349: HIVE-18544: Create tests to cover methods
for appending Partitions
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
> On Jan. 29, 2018, 11:15 a.m., Adam Szita wrote:
> > Thanks for the patch Marta, it looks very thourough! I've added my 2 cents: small observations regarding helper methods only.
Thanks a lot Adam for the review.
> On Jan. 29, 2018, 11:15 a.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java
> > Lines 489-495 (patched)
> > <https://reviews.apache.org/r/65349/diff/1/?file=1946930#file1946930line489>
> >
> > When defining table types we should rely on the enum values IMHO: TableType.EXTERNAL_TABLE.name()
You are right, thanks for pointing this out.
> On Jan. 29, 2018, 11:15 a.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java
> > Lines 536-539 (patched)
> > <https://reviews.apache.org/r/65349/diff/1/?file=1946930#file1946930line536>
> >
> > Another way of doing this is:
> >
> > Arrays.stream(input.split("/")).map(v->v.split("=")[1]).collect(toList())
Thanks for the hint, I fixed this.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/#review196418
-----------------------------------------------------------
On Jan. 29, 2018, 12:49 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65349/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 12:49 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18544
> https://issues.apache.org/jira/browse/HIVE-18544
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - Partition appendPartition(String, String, List<String>)
> - Partition appendPartition(String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65349/diff/2/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>
Re: Review Request 65349: HIVE-18544: Create tests to cover methods
for appending Partitions
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65349/#review196418
-----------------------------------------------------------
Thanks for the patch Marta, it looks very thourough! I've added my 2 cents: small observations regarding helper methods only.
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java
Lines 489-495 (patched)
<https://reviews.apache.org/r/65349/#comment276036>
When defining table types we should rely on the enum values IMHO: TableType.EXTERNAL_TABLE.name()
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java
Lines 536-539 (patched)
<https://reviews.apache.org/r/65349/#comment276035>
Another way of doing this is:
Arrays.stream(input.split("/")).map(v->v.split("=")[1]).collect(toList())
- Adam Szita
On Jan. 26, 2018, 1:03 p.m., Marta Kuczora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65349/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 1:03 p.m.)
>
>
> Review request for hive, Peter Vary and Adam Szita.
>
>
> Bugs: HIVE-18544
> https://issues.apache.org/jira/browse/HIVE-18544
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The following methods of IMetaStoreClient are covered by this test.
> - Partition appendPartition(String, String, List<String>)
> - Partition appendPartition(String, String, String)
>
> The test covers not just the happy pathes, but the edge cases as well.
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65349/diff/1/
>
>
> Testing
> -------
>
> Run the tests
>
>
> Thanks,
>
> Marta Kuczora
>
>