[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2800: Support to use `DISTINCT table.*`

[GitBox <gi...@apache.org>]

sunbufu commented on issue #2800: Support to use `DISTINCT table.*`
URL: https://github.com/apache/incubator-shardingsphere/pull/2800#issuecomment-518087640
 
 
   > And I notice the files:
   > 
   > * `sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/sharding/segment/select/item/engine/SelectItemsEngine.java` is missing test coverage.
   > * `sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java ` is with test coverage reduction.
   > 
   > Could you add test cases on those two files?
   
   HI, I don'k know why  `IpUtils`'s coverage is reduced, because I haven't modify anywhere in `IpUtils`.  In [report](https://coveralls.io/builds/24978607/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L64), `isPublicIpAddress()` return false, so next code can not be covered. I think maybe check environment is changed.
   ```java
                   if (isPublicIpAddress(ipAddress)) {
                       String publicIpAddress = ipAddress.getHostAddress();
                       cachedIpAddress = publicIpAddress;
                       return publicIpAddress;
                   }
   ```
   Can you give me some advice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services