[GitHub] [superset] pkdotson commented on a change in pull request #16208: fix: sorting modified by in charttable

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #16208:
URL: https://github.com/apache/superset/pull/16208#discussion_r687197175



##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -285,7 +285,7 @@ function ChartList(props: ChartListProps) {
           </a>
         ),
         Header: t('Modified by'),
-        accessor: 'last_saved_by',
+        accessor: 'last_saved_by.id',

Review comment:
       hmm should probably change this to .lastname then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org