You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "skytin1004 (via GitHub)" <gi...@apache.org> on 2023/05/15 08:12:23 UTC

[GitHub] [iceberg] skytin1004 commented on a diff in pull request #7609: Core: Migration to JUnit5 in avro

skytin1004 commented on code in PR #7609:
URL: https://github.com/apache/iceberg/pull/7609#discussion_r1193484413


##########
core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java:
##########
@@ -82,7 +82,7 @@ static void assertEquals(Types.StructType struct, Record expected, Record actual
   static void assertEquals(Types.ListType list, List<?> expected, List<?> actual) {
     Type elementType = list.elementType();
 
-    Assert.assertEquals("List size should match", expected.size(), actual.size());
+    org.junit.jupiter.api.Assertions.assertEquals(expected.size(), actual.size(),"List size should match");

Review Comment:
   Thank you. I will revise it again based on your review.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org