You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/22 01:30:57 UTC
[GitHub] [superset] zuzana-vej opened a new issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
zuzana-vej opened a new issue #12672:
URL: https://github.com/apache/superset/issues/12672
## Screenshot
Issue 1: No Save Button, however the configuration gets saved is user clicks outside the configuration popup. Is this expected behavior? Given all other settings have save button, it would be good for consistency to have the Save here too.
Issue 2:
Here the (i) wraps to a new line, consider keeping it inline (make the popup window slightly larger?)
## Description
Described above alongside screenshot.
## Design input
Confirm if the SAVE button should be on the "Time Series Columns" configuration popup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #12672:
URL: https://github.com/apache/superset/issues/12672#issuecomment-833459540
@junlincc I'm on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
rusackas closed issue #12672:
URL: https://github.com/apache/superset/issues/12672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12672:
URL: https://github.com/apache/superset/issues/12672#issuecomment-810604812
@junlincc curious if this might be prioritized not in near future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12672:
URL: https://github.com/apache/superset/issues/12672#issuecomment-765817714
> No Save Button, however the configuration gets saved is user clicks outside the configuration popup. Is this expected behavior?
It's not 😅, we came across this issue when we audit all charts but decided to let it go back then. agreed we should get it fixed.
> Here the (i) wraps to a new line, consider keeping it inline (make the popup window slightly larger?)
this is happening in many chart controls. we will see if we can get it fixed(in our Explore cosmetic bash) next week for patch release
Thank you for reporting 🙏 @zuzana-vej
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12672:
URL: https://github.com/apache/superset/issues/12672#issuecomment-786197873
Low pri bug, but wanted to ping a reminder so that it's not completely lost. cc @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12672:
URL: https://github.com/apache/superset/issues/12672#issuecomment-810747886
we will have a bash for all the `good first issue` in mid May
cc @amitmiran137 thanks for organizing 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #12672: [explore] Time Series Columns Configuration - no save button, (i) wrapped to new line
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12672:
URL: https://github.com/apache/superset/issues/12672#issuecomment-833727042
Thank you @michael-s-molina!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org