[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9966: Use gson JSONParser for asserting JSON equality deterministically

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9966:
URL: https://github.com/apache/pinot/pull/9966#discussion_r1046450757


##########
pinot-common/src/test/java/org/apache/pinot/common/utils/PinotDataTypeTest.java:
##########
@@ -18,6 +18,7 @@
  */
 package org.apache.pinot.common.utils;
 
+import com.google.gson.JsonParser;

Review Comment:
   Within Pinot, we try to unify the usage of json library to `fasterxml.jackson`. You may use `JsonUtils.stringToJsonNode()` to convert the string to JsonNode and then compare.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org