You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/01/30 20:31:49 UTC

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist 

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15137


Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................

IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Currently, the ClusterMembershipMgr will remove a node from the
blacklist whenever there is an "update" for a backend from the statestore.
Updates are typically restricted to updates about the quiescing status
of a node. The ClusterMembershipMgr should un-blacklist quiescing nodes
since quiescing nodes are not part of any executor groups and will
eventually be removed from the cluster membership. Thus, there is no
reason they need to remain on the blacklist.

However, other updates to a backend (e.g. updates that are not related
to the quiescing status of a node) should not cause that node to be
un-blacklisted. Doing so could cause a node to be un-blacklisted, but
not added back to any executor groups, creating a state where a node is
part of the cluster membership, but not part of any executor groups (or
the blacklist).

This patch fixes the aforementioned issue by only un-blacklisting an
updated node in ClusterMembershipMgr::UpdateMembership when the node
starts quiescing. Added some DCHECKs to ensure the consistency of the
blacklist and the list of executor groups.

Testing:
* Ran core tests
* Ran test_executor_groups.p, test_restart_services.py,
  and test_blacklist.py with --exploration_strategy=exhaustive
  locally

Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
---
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
2 files changed, 32 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15137/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 01:58:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5480/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 01:58:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5555/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 21:16:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................

IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Currently, the ClusterMembershipMgr will remove a node from the
blacklist whenever there is an "update" for a backend from the statestore.
Updates are typically restricted to updates about the quiescing status
of a node. The ClusterMembershipMgr should un-blacklist quiescing nodes
since quiescing nodes are not part of any executor groups and will
eventually be removed from the cluster membership. Thus, there is no
reason they need to remain on the blacklist.

However, other updates to a backend (e.g. updates that are not related
to the quiescing status of a node) should not cause that node to be
un-blacklisted. Doing so could cause a node to be un-blacklisted, but
not added back to any executor groups, creating a state where a node is
part of the cluster membership, but not part of any executor groups (or
the blacklist).

This patch fixes the aforementioned issue by only un-blacklisting an
updated node in ClusterMembershipMgr::UpdateMembership when the node
starts quiescing. Added some DCHECKs to ensure the consistency of the
blacklist and the list of executor groups.

Testing:
* Ran core tests
* Ran test_executor_groups.p, test_restart_services.py,
  and test_blacklist.py with --exploration_strategy=exhaustive
  locally

Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Reviewed-on: http://gerrit.cloudera.org:8080/15137
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
2 files changed, 41 insertions(+), 12 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 5
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.h
File be/src/scheduling/cluster-membership-mgr.h:

http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.h@203
PS1, Line 203:   /// Returns true if the 'be_desc' is in any of the 'executor_groups', false otherwise.
> Maybe note this is intended for use in DCHECKs
Done


http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.cc@257
PS1, Line 257:       if (be_desc.is_quiescing && !existing.is_quiescing && existing.is_executor) {
> Maybe also add a DCHECK that if 'existing.is_quiescing' is true then 'be_de
Added the DCHECK.

I tried debugging it, but couldn't really pinpoint the issue. It only happens on cluster startup. Removing nodes / adding nodes doesn't seem to trigger it. Only graceful shutdown.

I think either way it is probably safest to make the blacklisting logic specific to quiescing nodes in case we change the triggers for an UPDATE at some time in the future.


http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.cc@266
PS1, Line 266: } else {
> formatting
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 23:07:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5480/


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 06:45:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5560/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 23:52:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.h
File be/src/scheduling/cluster-membership-mgr.h:

http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.h@203
PS1, Line 203:   /// Returns true if the 'be_desc' is in any of the 'executor_groups', false otherwise.
Maybe note this is intended for use in DCHECKs


http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.cc@257
PS1, Line 257:       if (be_desc.is_quiescing && !existing.is_quiescing && existing.is_executor) {
Maybe also add a DCHECK that if 'existing.is_quiescing' is true then 'be_desc.is_quiescing' is also true, based on Bikram asying that once a node starts quiescing it will never transfer back.

It would also of course be nice if we understood what other updates are possible and could document them, while you're here, but not a big deal if you don't want to spend time on figuring it out.


http://gerrit.cloudera.org:8080/#/c/15137/1/be/src/scheduling/cluster-membership-mgr.cc@266
PS1, Line 266: } else {
formatting



-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 21:19:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5288/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 16:02:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 16:02:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 20:54:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15137 )

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 23:54:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15137

to look at the new patch set (#2).

Change subject: IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist
......................................................................

IMPALA-9342: Membership updates should only remove quiescing nodes from the blacklist

Currently, the ClusterMembershipMgr will remove a node from the
blacklist whenever there is an "update" for a backend from the statestore.
Updates are typically restricted to updates about the quiescing status
of a node. The ClusterMembershipMgr should un-blacklist quiescing nodes
since quiescing nodes are not part of any executor groups and will
eventually be removed from the cluster membership. Thus, there is no
reason they need to remain on the blacklist.

However, other updates to a backend (e.g. updates that are not related
to the quiescing status of a node) should not cause that node to be
un-blacklisted. Doing so could cause a node to be un-blacklisted, but
not added back to any executor groups, creating a state where a node is
part of the cluster membership, but not part of any executor groups (or
the blacklist).

This patch fixes the aforementioned issue by only un-blacklisting an
updated node in ClusterMembershipMgr::UpdateMembership when the node
starts quiescing. Added some DCHECKs to ensure the consistency of the
blacklist and the list of executor groups.

Testing:
* Ran core tests
* Ran test_executor_groups.p, test_restart_services.py,
  and test_blacklist.py with --exploration_strategy=exhaustive
  locally

Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
---
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
2 files changed, 41 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15137/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id062e51df86315ac214d30db882736dbb7948a77
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>