You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/08/12 09:08:11 UTC

Review Request 24595: Invoke cbo only when needed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24595/
-----------------------------------------------------------

Review request for hive and John Pullokkaran.


Bugs: HIVE-7687
    https://issues.apache.org/jira/browse/HIVE-7687


Repository: hive


Description
-------

Invoke cbo only when needed


Diffs
-----

  branches/cbo/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1617414 
  branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1617414 

Diff: https://reviews.apache.org/r/24595/diff/


Testing
-------


Thanks,

Ashutosh Chauhan


Re: Review Request 24595: Invoke cbo only when needed

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24595/#review50354
-----------------------------------------------------------



branches/cbo/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/24595/#comment88061>

    Remove other two config.



branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/24595/#comment88062>

    Don't check for join count. Let it run through CBO regardless of whether it has Join or not.


- John Pullokkaran


On Aug. 12, 2014, 7:08 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24595/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 7:08 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-7687
>     https://issues.apache.org/jira/browse/HIVE-7687
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> Invoke cbo only when needed
> 
> 
> Diffs
> -----
> 
>   branches/cbo/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1617414 
>   branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1617414 
> 
> Diff: https://reviews.apache.org/r/24595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>