You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2017/09/28 11:45:51 UTC
[GitHub] carbondata pull request #1395: [CARBONDATA-1533] Fixed decimal data load fai...
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1395
[CARBONDATA-1533] Fixed decimal data load fail issue and restricted max characters per column
1. Fixed data load failure when both precision and data falls in integer range for decimal data type
Analysis: When precision is <=9 for decimal data type then by default integer type is selected for storing decimal data. Data is further compressed by checking min and max value range of data. If data is such that it falls in the Integer range only then exception is thrown during data load as encode method is not handling integer data type data during data load.
2. Restricted max characters per column to 32000 as we use short to store the length of each column
Analysis: Short data type is used to store length of each column in unsafe carbon row while writing data to off heap. If length is more than Short value then values goes into negative and while reading the same data negative array size exception is thrown.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishgupta88/carbondata decimal_int_range_issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1395
----
commit 5066935dc5cd6f9873cda794b2e71d9431983996
Author: manishgupta88 <to...@gmail.com>
Date: 2017-09-28T11:33:46Z
1. Fixed data load bug failure when both precision and data fal in integer range for decimal data type
2. Restricted max characters per column to 32000 as we use short to store the length of each column
----
---
[GitHub] carbondata pull request #1395: [CARBONDATA-1533] Fixed decimal data load fai...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1395
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1395
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/322/
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1395
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/989/
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1395
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/237/
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1395
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/198/
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1395
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/361/
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1395
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/950/
---
[GitHub] carbondata issue #1395: [CARBONDATA-1533] Fixed decimal data load fail issue...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1395
LGTM
---