You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 17:24:37 UTC

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11341: [BEAM-9720] Add Aws Http client configurations capability.

aromanenko-dev commented on a change in pull request #11341:
URL: https://github.com/apache/beam/pull/11341#discussion_r416788917



##########
File path: sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsOptions.java
##########
@@ -103,6 +103,34 @@ public AWSCredentialsProvider create(PipelineOptions options) {
 
   void setClientConfiguration(ClientConfiguration clientConfiguration);

Review comment:
       Are `setClientConfiguration` and `getClientConfiguration` still valid?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org