You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jimmynavio <gi...@git.apache.org> on 2015/10/05 21:08:17 UTC

[GitHub] thrift pull request: Fix bad links to coding_standards.md

GitHub user jimmynavio opened a pull request:

    https://github.com/apache/thrift/pull/634

    Fix bad links to coding_standards.md

    I noticed the other bad links to coding_standards.md had been fixed, and somehow CONTRIBUTING.md was missed. This is bad news bears since CONTRIBUTING.md is directly referenced by https://thrift.apache.org/docs/HowToContribute - which means these are currently broken on the live site.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jimmynavio/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #634
    
----
commit e0384be3d5a80b82d45271d5760da8ed8801e707
Author: Paul Royer <wm...@gmail.com>
Date:   2015-10-05T19:03:06Z

    Fix bad links to coding_standards.md

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fix bad links to coding_standards.md

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/634#issuecomment-145637544
  
    Too bad you didn't really read the document ;-)  
    => tracked in THRIFT-3367



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fix bad links to coding_standards.md

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---