You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mod_python-commits@quetz.apache.org by gr...@apache.org on 2004/01/14 03:43:18 UTC

cvs commit: httpd-python/src mod_python.c

grisha      2004/01/13 18:43:18

  Modified:    src      mod_python.c
  Log:
  Corrected the problem reported by Stian S�iland. When req.user is NULL
  after AuthenHandler, it a problem *only* when the return status is OK.
  
  Revision  Changes    Path
  1.110     +3 -3      httpd-python/src/mod_python.c
  
  Index: mod_python.c
  ===================================================================
  RCS file: /home/cvs/httpd-python/src/mod_python.c,v
  retrieving revision 1.109
  retrieving revision 1.110
  diff -u -r1.109 -r1.110
  --- mod_python.c	4 Nov 2003 21:26:29 -0000	1.109
  +++ mod_python.c	14 Jan 2004 02:43:18 -0000	1.110
  @@ -1107,10 +1107,10 @@
                      in mod_auth.c whereby r->user is used even if null.
                      XXX Remove in the future
                   */
  -                if (!req->user) {
  +                if (result == OK && !req->user) {
                       ap_log_rerror(APLOG_MARK, APLOG_NOERRNO|APLOG_ERR, 0, req,
                                     "python_handler: After PythonAuthenHandler req->user is NULL. "
  -                                  "Assign req.user to avoid this error.");
  +                                  "Assign something to req.user if returning OK to avoid this error.");
                       return HTTP_INTERNAL_SERVER_ERROR;
                   }
                   if (result == HTTP_UNAUTHORIZED)