You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dave (JIRA)" <de...@myfaces.apache.org> on 2009/05/03 14:09:30 UTC

[jira] Created: (TOMAHAWK-1418) UISaveState is included in htmlTag param map

UISaveState is included in htmlTag param map
--------------------------------------------

                 Key: TOMAHAWK-1418
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1418
             Project: MyFaces Tomahawk
          Issue Type: Bug
    Affects Versions: 1.1.8
         Environment: JBOSS 5.0.1, XP, JSF ri 1.2, Tomahawk 1.1.8
            Reporter: Dave


<t:div>
<t:saveState .../>

</t:div>

<saveState> are included as <f:param> for htmlTagRender.


HtmlComponentUtils.java

  public static Map getParameterMap(UIComponent component) {
        Map result = new HashMap();
        for (Iterator iter = component.getChildren().iterator(); iter.hasNext();) {
            UIComponent child = (UIComponent) iter.next();
            if (child instanceof UIParameter) {
                UIParameter uiparam = (UIParameter) child;
                Object value = uiparam.getValue();
                if (value != null) {
                    result.put(uiparam.getName(), value);
                }
            }
        }
        return result;
    }   

----------fix:----------------
parameterMap is for <f:param> only.

so change the following:
if (child instanceof UIParameter)  --> if (child.getClass().equals(UIParameter.class))




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-1418) UISaveState is included in htmlTag param map

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1418.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.9-SNAPSHOT
         Assignee: Leonardo Uribe

We can't change HtmlComponentUtils.getParameterMap, but this case is special, so we can move the related code to the rendered and change it as suggested. Thanks for the tip.

> UISaveState is included in htmlTag param map
> --------------------------------------------
>
>                 Key: TOMAHAWK-1418
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1418
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.8
>         Environment: JBOSS 5.0.1, XP, JSF ri 1.2, Tomahawk 1.1.8
>            Reporter: Dave
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9-SNAPSHOT
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> <t:div>
> <t:saveState .../>
> </t:div>
> <saveState> are included as <f:param> for htmlTagRender.
> HtmlComponentUtils.java
>   public static Map getParameterMap(UIComponent component) {
>         Map result = new HashMap();
>         for (Iterator iter = component.getChildren().iterator(); iter.hasNext();) {
>             UIComponent child = (UIComponent) iter.next();
>             if (child instanceof UIParameter) {
>                 UIParameter uiparam = (UIParameter) child;
>                 Object value = uiparam.getValue();
>                 if (value != null) {
>                     result.put(uiparam.getName(), value);
>                 }
>             }
>         }
>         return result;
>     }   
> ----------fix:----------------
> parameterMap is for <f:param> only.
> so change the following:
> if (child instanceof UIParameter)  --> if (child.getClass().equals(UIParameter.class))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1418) UISaveState is included in htmlTag param map

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705413#action_12705413 ] 

Dave commented on TOMAHAWK-1418:
--------------------------------

UISaveState is subclass of UIParameter

> UISaveState is included in htmlTag param map
> --------------------------------------------
>
>                 Key: TOMAHAWK-1418
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1418
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.8
>         Environment: JBOSS 5.0.1, XP, JSF ri 1.2, Tomahawk 1.1.8
>            Reporter: Dave
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> <t:div>
> <t:saveState .../>
> </t:div>
> <saveState> are included as <f:param> for htmlTagRender.
> HtmlComponentUtils.java
>   public static Map getParameterMap(UIComponent component) {
>         Map result = new HashMap();
>         for (Iterator iter = component.getChildren().iterator(); iter.hasNext();) {
>             UIComponent child = (UIComponent) iter.next();
>             if (child instanceof UIParameter) {
>                 UIParameter uiparam = (UIParameter) child;
>                 Object value = uiparam.getValue();
>                 if (value != null) {
>                     result.put(uiparam.getName(), value);
>                 }
>             }
>         }
>         return result;
>     }   
> ----------fix:----------------
> parameterMap is for <f:param> only.
> so change the following:
> if (child instanceof UIParameter)  --> if (child.getClass().equals(UIParameter.class))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.