You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Keith Wannamaker <Ke...@Wannamaker.org> on 2002/05/18 03:25:39 UTC

[PATCH] jspc classloader was RE: classloader for factories

What do you think about adding a cp property to find
the adaptor, like this?  

Keith

| -----Original Message-----
| From: Steve Loughran [mailto:steve_l@iseran.com]
| Sent: Friday, May 17, 2002 3:39 PM
| To: Ant Developers List
| Subject: Re: classloader for factories
| 
| Fixing classloader defects is usually viewed as an ant2.0 feature, cos the
| probability of breaking so much is high. but if you could come up with a
| good solution that doesnt introduce issues, that would be great.

RE: [PATCH] jspc classloader was RE: classloader for factories

Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
Ok, turns out the Jasper2 in jakarta-tomcat-jasper
as well as the Jasper in tomcat 4.0-head are broken.

The Jasper in TC 3.3 works fine, but fails one of the mangling tests.

I'm going to use TC 3.3 Jasper, ignoring the mangling test for now,
to create the tests you requested.

FYI the error in Jasper looks like --
  [wannamak@piper optional]$ java org.apache.jasper.JspC
   -d /usr/local/cvs/jakarta-ant/src/etc/testcases/taskdefs/optional/jsp/java
      /usr/local/cvs/jakarta-ant/src/etc/testcases/taskdefs/optional/jsp/simple.jsp
   2002-05-20 01:37:21 - ERROR-the file '/simple.jsp' generated the following
   general exception: java.lang.NullPointerException
   java.lang.NullPointerException
        at java.io.FileOutputStream.open(Native Method)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:102)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:62)
        at org.apache.jasper.compiler.Compiler.compile(Unknown Source)
        at org.apache.jasper.JspC.parseFile(Unknown Source)
        at org.apache.jasper.JspC.parseFiles(Unknown Source)
        at org.apache.jasper.JspC.main(Unknown Source)

Keith

| -----Original Message-----
| From: Keith Wannamaker [mailto:Keith@wannamaker.org]
| Sent: Monday, May 20, 2002 1:10 PM
| To: Ant Developers List
| Subject: RE: [PATCH] jspc classloader was RE: classloader for factories
| 
| 
| Bingo, by running jspc.xml directly I got the real error --
| realized I didn't have all the jasper dependencies in the cp.
| Now working on making an appropriate testcase..
| 
| | Wondering if you wouldn't mind running the JspcTest on your
| | box as a quick sanity check for me?
| | 
| | Keith


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: [PATCH] jspc classloader was RE: classloader for factories

Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
Bingo, by running jspc.xml directly I got the real error --
realized I didn't have all the jasper dependencies in the cp.
Now working on making an appropriate testcase..

| Wondering if you wouldn't mind running the JspcTest on your
| box as a quick sanity check for me?
| 
| Keith


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: [PATCH] jspc classloader was RE: classloader for factories

Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
| 1. gump may not run it every night

True, and in fact, right on the money.  The jspc test is not
run (presumably because jasper isn't made available).

| 2.you are running java1,4, arent you

No Sun 1.3.0_02 on NT4.

Wondering if you wouldn't mind running the JspcTest on your
box as a quick sanity check for me?

Keith


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] jspc classloader was RE: classloader for factories

Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Keith Wannamaker" <Ke...@Wannamaker.org>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Monday, May 20, 2002 9:45 AM
Subject: RE: [PATCH] jspc classloader was RE: classloader for factories


> Steve,
> argh, no not yet.  I'm getting errors with the existing jspc
> tests on a fresh extract.  Clearly it is a local issue since
> gump runs the thing every night.  The trouble is difficult
> to debug because stderr/stdout are not being dumped from the
> task:

1. gump may not run it every night

>     [junit] Testcase:
testSimple(org.apache.tools.ant.taskdefs.optional.JspcTest
> ):      Caused an ERROR
>     [junit] Java returned: 1
>     [junit]
/usr/local/cvs/jakarta-ant/src/etc/testcases/taskdefs/optional/jspc.
> xml:37: Java returned: 1
>     [junit]     at
org.apache.tools.ant.taskdefs.Java.execute(Java.java:110)
>
> Any ideas how to get at the actual compiler error?

2.you are running java1,4, arent you

>
> Keith
>
> | -----Original Message-----
> | From: Steve Loughran [mailto:steve_l@iseran.com]
> | Sent: Saturday, May 18, 2002 10:47 AM
> | To: Ant Developers List
> | Subject: Re: [PATCH] jspc classloader was RE: classloader for factories
> |
> |
> | looks good to me. do we have a test yet?
> |
>
>
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: [PATCH] jspc classloader was RE: classloader for factories

Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
Steve,
argh, no not yet.  I'm getting errors with the existing jspc
tests on a fresh extract.  Clearly it is a local issue since
gump runs the thing every night.  The trouble is difficult
to debug because stderr/stdout are not being dumped from the
task:

    [junit] Testcase: testSimple(org.apache.tools.ant.taskdefs.optional.JspcTest
):      Caused an ERROR
    [junit] Java returned: 1
    [junit] /usr/local/cvs/jakarta-ant/src/etc/testcases/taskdefs/optional/jspc.
xml:37: Java returned: 1
    [junit]     at org.apache.tools.ant.taskdefs.Java.execute(Java.java:110)

Any ideas how to get at the actual compiler error?

Keith

| -----Original Message-----
| From: Steve Loughran [mailto:steve_l@iseran.com]
| Sent: Saturday, May 18, 2002 10:47 AM
| To: Ant Developers List
| Subject: Re: [PATCH] jspc classloader was RE: classloader for factories
|
|
| looks good to me. do we have a test yet?
|


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] jspc classloader was RE: classloader for factories

Posted by Steve Loughran <st...@iseran.com>.
looks good to me. do we have a test yet?

----- Original Message -----
From: "Keith Wannamaker" <Ke...@Wannamaker.org>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 17, 2002 6:25 PM
Subject: [PATCH] jspc classloader was RE: classloader for factories


> What do you think about adding a cp property to find
> the adaptor, like this?
>
> Keith
>
> | -----Original Message-----
> | From: Steve Loughran [mailto:steve_l@iseran.com]
> | Sent: Friday, May 17, 2002 3:39 PM
> | To: Ant Developers List
> | Subject: Re: classloader for factories
> |
> | Fixing classloader defects is usually viewed as an ant2.0 feature, cos
the
> | probability of breaking so much is high. but if you could come up with a
> | good solution that doesnt introduce issues, that would be great.
>


----------------------------------------------------------------------------
----


> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>