You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/26 19:11:37 UTC

Review Request 39663: RU - Downgrade from 2.3 to 2.2 may fail if configs were not back'ed up

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39663/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-13568
    https://issues.apache.org/jira/browse/AMBARI-13568


Repository: ambari


Description
-------

Decided to downgrade before the configs were back'ed up, so in ru_set_all.py's _unlink_config() method, it failed while calling "mv".

Fixed the python code to corespond to method pydoc


Diffs
-----

  ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 6e5ddd2 
  ambari-server/src/test/python/custom_actions/test_ru_set_all.py b102b4e 

Diff: https://reviews.apache.org/r/39663/diff/


Testing
-------

----------------------------------------------------------------------
Total run:859
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko


Re: Review Request 39663: RU - Downgrade from 2.3 to 2.2 may fail if configs were not back'ed up

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39663/#review104060
-----------------------------------------------------------

Ship it!


Thanks for this fix.

- Alejandro Fernandez


On Oct. 26, 2015, 6:11 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39663/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 6:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-13568
>     https://issues.apache.org/jira/browse/AMBARI-13568
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Decided to downgrade before the configs were back'ed up, so in ru_set_all.py's _unlink_config() method, it failed while calling "mv".
> 
> Fixed the python code to corespond to method pydoc
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 6e5ddd2 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py b102b4e 
> 
> Diff: https://reviews.apache.org/r/39663/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:859
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>