You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2018/10/18 04:17:56 UTC

[beam] branch master updated: [BEAM-5780] Update comment (#6734)

This is an automated email from the ASF dual-hosted git repository.

lcwik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 0acb027  [BEAM-5780] Update comment (#6734)
0acb027 is described below

commit 0acb027cd7d909732e5a07ed0d2cbbedf5fbc907
Author: Lukasz Cwik <lc...@google.com>
AuthorDate: Wed Oct 17 21:17:49 2018 -0700

    [BEAM-5780] Update comment (#6734)
---
 .../worker/legacy-worker/build.gradle                          | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle b/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
index 3b45dd0..a423444 100644
--- a/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
+++ b/runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
@@ -17,11 +17,11 @@
  */
 
 // There is no actual src dir under legacy-worker/ since legacy-worker is built against the
-// same sourceSets as fn-api-worker. The reason why legacy-worker has a separated dir is:
-// 1. Instead of point both legacy-worker and fn-api-worker project to the same worker/,
-// make them point to different dirs.
-// 2. Make built artifacts and test reports go to worker/build for fn-api-worker and
-// legacy-worker/build for legacy worker.
+// same sourceSet as fn-api-worker. The reason why legacy-worker has a separated dir is:
+// 1. Have one location for editing worker code which is built and tested in two
+//    different ways.
+// 2. Not have artifacts such as test results and jars write over each other.
+// 3. Better compatibility with Intellij since Intellij requires separate content roots.
 
 apply plugin: org.apache.beam.gradle.BeamModulePlugin