You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2022/06/17 12:17:03 UTC

[GitHub] [syncope] ilgrosso opened a new pull request, #352: Checkstyle improvements: import ordering and test code

ilgrosso opened a new pull request, #352:
URL: https://github.com/apache/syncope/pull/352

   This PR will improve the current Checkstyle definition by:
   
   * extending checks to test code (currently not included)
   * verifying that import statements are properly grouped and ordered


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #352: Checkstyle improvements: import ordering and test code

Posted by GitBox <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #352:
URL: https://github.com/apache/syncope/pull/352#discussion_r900080455


##########
core/provisioning-api/src/test/java/org/apache/syncope/core/provisioning/api/utils/JexlUtilsTest.java:
##########
@@ -152,10 +154,11 @@
 
     @Test
     public void evaluateMandatoryCondition(
-            @Mock DerAttrHandler derAttrHandler,
-            @Mock Any<?> any,
-            @Mock DerSchema derSchema,
-            @Mock Collection<? extends PlainAttr<?>> plainAttrs) {
+            final @Mock DerAttrHandler derAttrHandler,
+            final @Mock Any<?> any,
+            final @Mock DerSchema derSchema,
+            final @Mock Collection<? extends PlainAttr<?>> plainAttrs) {

Review Comment:
   ## Useless parameter
   
   The parameter plainAttrs is unused.
   
   [Show more details](https://github.com/apache/syncope/security/code-scanning/1035)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso merged pull request #352: Checkstyle improvements: import ordering and test code

Posted by GitBox <gi...@apache.org>.
ilgrosso merged PR #352:
URL: https://github.com/apache/syncope/pull/352


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org