You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/02/20 07:07:33 UTC

[jclouds] JCLOUDS-410: Remove FilePayload (#300)

Use ByteSourcePayload instead.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds remove-file-payload

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/300

-- Commit Summary --

  * JCLOUDS-410: Remove FilePayload

-- File Changes --

    M apis/filesystem/src/test/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImplTest.java (8)
    M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (2)
    M core/src/main/java/org/jclouds/http/HttpMessage.java (11)
    M core/src/main/java/org/jclouds/io/Payloads.java (12)
    D core/src/main/java/org/jclouds/io/payloads/FilePayload.java (48)
    M core/src/main/java/org/jclouds/io/payloads/Part.java (2)
    M core/src/test/java/org/jclouds/io/payloads/MultipartFormTest.java (53)
    M drivers/apachehc/src/main/java/org/jclouds/http/apachehc/ApacheHCUtils.java (6)
    M drivers/gae/src/test/java/org/jclouds/gae/ConvertToGaeRequestTest.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/300.patch
https://github.com/jclouds/jclouds/pull/300.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #613](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/613/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-35593413

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Andrew Gaul <no...@github.com>.
Needs some more thought.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-47618662

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1084](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1084/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-35593471

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Ignasi Barrera <no...@github.com>.
Do we have any update on this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-43868925

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Ignasi Barrera <no...@github.com>.
Also take into account that it is also [used in jclouds-chef](https://github.com/jclouds/jclouds-chef/blob/master/core/src/main/java/org/jclouds/chef/domain/Resource.java#L69). It's just a reminder so we don't forget :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-47654832

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Andrew Gaul <no...@github.com>.
Closed #300.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#event-136822366

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #860](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/860/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-35594427

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Andrew Phillips <no...@github.com>.
@andrewgaul: Ping on this? Looks like it needs a rebase...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-46953854

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Andrew Gaul <no...@github.com>.
Real failures; investigating.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-35594241

Re: [jclouds] JCLOUDS-410: Remove FilePayload (#300)

Posted by Andrew Phillips <no...@github.com>.
Symptoms seem to be:

> Content-Disposition: form-data; name="file"; filename="testfile.txt"

vs.

> Content-Disposition: form-data; name="file"

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/300#issuecomment-35598535