You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/22 07:13:11 UTC

[GitHub] [cloudstack] Pearl1594 commented on pull request #4341: Allow to configure root disk size via Service Offering (diskoffering of type Service).

Pearl1594 commented on pull request #4341:
URL: https://github.com/apache/cloudstack/pull/4341#issuecomment-714283963


   Code LGTM 
   But noticed a behavioral difference between the Legacy UI and Primate @GabrielBrascher. Seems like Primate calls changeServiceForVirtualMachine when the VM is stopped and an attempt is made to scale - as a result of which most observations expected aren't seen i.e., on scaling up to an offering with a rootdisksize > current root disk size, though the operation is successful, there is no change in the disksize parameter of listVolumesMetrics. Also, scaling it down (to a service offering with lower rootdisksize value than the current size) works via primate for the same reason.
   All mentioned cases work fine via legacy UI.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org