You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Prasanna Santhanam <Pr...@citrix.com> on 2012/09/20 10:39:21 UTC
Review Request: Distclean target for waf to remove old build artifacts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7188/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Distclean target for waf to remove old build artifacts
1. Need to add this step
$./waf distclean
before firing builds on jenkins.c.o to prevent artifacts building up
PatchFile: https://gist.github.com/3754685
Diffs
-----
wscript f1c9b62
Diff: https://reviews.apache.org/r/7188/diff/
Testing
-------
root@cloud:~/incubator-cloudstack# for i in {1..10}
> do
> touch artifacts/test$i
> done
root@cloud:~/incubator-cloudstack# ./waf distclean
Removing artifact artifacts/test10
Removing artifact artifacts/test5
Removing artifact artifacts/test9
Removing artifact artifacts/test7
Removing artifact artifacts/test1
Removing artifact artifacts/test4
Removing artifact artifacts/test2
Removing artifact artifacts/test8
Removing artifact artifacts/test3
Removing artifact artifacts/test6
'distclean' finished successfully (0.003s)
Thanks,
Prasanna Santhanam
Re: Review Request: Distclean target for waf to remove old build artifacts
Posted by Rohit Yadav <ro...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7188/#review11738
-----------------------------------------------------------
Ship it!
We want that for Jenkins to stay sane. Thanks for the patch!
- Rohit Yadav
On Sept. 20, 2012, 8:39 a.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7188/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 8:39 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Distclean target for waf to remove old build artifacts
>
> 1. Need to add this step
> $./waf distclean
> before firing builds on jenkins.c.o to prevent artifacts building up
>
> PatchFile: https://gist.github.com/3754685
>
>
> Diffs
> -----
>
> wscript f1c9b62
>
> Diff: https://reviews.apache.org/r/7188/diff/
>
>
> Testing
> -------
>
> root@cloud:~/incubator-cloudstack# for i in {1..10}
> > do
> > touch artifacts/test$i
> > done
>
> root@cloud:~/incubator-cloudstack# ./waf distclean
> Removing artifact artifacts/test10
> Removing artifact artifacts/test5
> Removing artifact artifacts/test9
> Removing artifact artifacts/test7
> Removing artifact artifacts/test1
> Removing artifact artifacts/test4
> Removing artifact artifacts/test2
> Removing artifact artifacts/test8
> Removing artifact artifacts/test3
> Removing artifact artifacts/test6
> 'distclean' finished successfully (0.003s)
>
>
> Thanks,
>
> Prasanna Santhanam
>
>
Re: Review Request: Distclean target for waf to remove old build artifacts
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7188/#review11752
-----------------------------------------------------------
Don't need to depend on waf, we can just remove artifacts folder before build binary.
- edison su
On Sept. 20, 2012, 8:39 a.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7188/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 8:39 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Distclean target for waf to remove old build artifacts
>
> 1. Need to add this step
> $./waf distclean
> before firing builds on jenkins.c.o to prevent artifacts building up
>
> PatchFile: https://gist.github.com/3754685
>
>
> Diffs
> -----
>
> wscript f1c9b62
>
> Diff: https://reviews.apache.org/r/7188/diff/
>
>
> Testing
> -------
>
> root@cloud:~/incubator-cloudstack# for i in {1..10}
> > do
> > touch artifacts/test$i
> > done
>
> root@cloud:~/incubator-cloudstack# ./waf distclean
> Removing artifact artifacts/test10
> Removing artifact artifacts/test5
> Removing artifact artifacts/test9
> Removing artifact artifacts/test7
> Removing artifact artifacts/test1
> Removing artifact artifacts/test4
> Removing artifact artifacts/test2
> Removing artifact artifacts/test8
> Removing artifact artifacts/test3
> Removing artifact artifacts/test6
> 'distclean' finished successfully (0.003s)
>
>
> Thanks,
>
> Prasanna Santhanam
>
>