You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/08 12:05:21 UTC

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #930: Fixed incorrect documentation

garydgregory commented on code in PR #930:
URL: https://github.com/apache/commons-lang/pull/930#discussion_r940159023


##########
src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java:
##########
@@ -100,6 +100,7 @@
      *            test is enabled and returns true.  The result of this test
      *            is never changed throughout the life of this {@link DiffBuilder}.
      * @throws IllegalArgumentException
+     * @throws NullPointerException

Review Comment:
   Indentation does not seem to match what's above.



##########
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java:
##########
@@ -352,7 +352,8 @@ public static int reflectionHashCode(final int initialNonZeroOddNumber, final in
      *             if the Object is {@code null}
      * @throws IllegalArgumentException
      *             if the number is zero or even
-     *
+     * @throws NullPointerException
+     *			   if the Object is {@code null}

Review Comment:
   Indentation does not seem to match what's above. Name the parameter, not a generic type like Object.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org