[jira] [Commented] (CALCITE-2670) Combine similar JSON aggregate functions in operator table

["Hongze Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706188#comment-16706188 ] 

Hongze Zhang commented on CALCITE-2670:
---------------------------------------

[~julianhyde] Sorry for pinging you again - I know you are busy on the new release. But do you think whether we could bring this to release 1.18 too (along with CALCITE-2266) {color:#333333}?{color} So that users need not to change their implementation in future versions if they implemented JSON_ARRAYAGG on top of 1.18.

> Combine similar JSON aggregate functions in operator table
> ----------------------------------------------------------
>
>                 Key: CALCITE-2670
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2670
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Hongze Zhang
>            Assignee: Julian Hyde
>            Priority: Major
>
> In current code master of Calcite, operator *JSON_ARRAYAGG* and *JSON_OBJECTAGG* are separated to *JSON_ARRAYAGG_NULL_ON_NULL*, *JSON_ARRAYAGG_ABSENT_ON_NULL*, *JSON_OBJECTAGG_NULL_ON_NULL* and *JSON_OBJECTAGG_ABSENT_ON_NULL* in SqlStdOperatorTable.java. This is OK for now, but may deliver more difficulty on extending syntax of *JSON_ARRAYAGG* and *JSON_OBJECTAGG* and on implementing logical plan by adapters.
> This is basically to combine the 4 operators to 2, this is a improvement list:
>  # Combine *JSON_ARRAYAGG_NULL_ON_NULL* and *JSON_ARRAYAGG_ABSENT_ON_NULL;*
>  # Combine *JSON_OBJECTAGG_NULL_ON_NULL* and *JSON_OBJECTAGG_ABSENT_ON_NULL;*
>  # *SYMBOL* type Support for *JavaTypeFactoryImpl#getJavaClass* This is to generate *Enum* java type for *SYMBOL;*
>  # Add SQL-to-Rel test cases for JSON functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)