[GitHub] [airflow] jedcunningham commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

[GitBox <gi...@apache.org>]

jedcunningham commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-922005341


   @kimyen, that test is overly fragile as written. Easy fix though: #18332
   
   I don't think that test exists yet, and I agree it would be a valuable test. The broken test is a reasonable example to follow, just check the default `volumes` and `volumeMounts` instead. More than 1 way to approach this, but one would be to use parameterized.expand like so:
   ```
   @parameterized.expand([
       ("1.10.10", False),
       ("1.10.12", True),
       ("2.1.0", True),
   ])
   def test_default_volumes_and_mounts(self, af_version, pod_template_file_expected):
       # assert "always there" volumes/mounts
       if pod_template_file_expected:
           # assert pod_template_file mount   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org