You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/19 18:03:01 UTC
[GitHub] [nifi] pvillard31 opened a new pull request, #6797: NIFI-10992 - Option to build all include-x profiles
pvillard31 opened a new pull request, #6797:
URL: https://github.com/apache/nifi/pull/6797
# Summary
[NIFI-10992](https://issues.apache.org/jira/browse/NIFI-10992)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #6797: NIFI-10992 - Option to build all include-x profiles
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on PR #6797:
URL: https://github.com/apache/nifi/pull/6797#issuecomment-1382709897
Thanks @ChrisSamo632 for the feedback, this is a fair point. I adjusted the PR to have an ``include-all`` profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #6797: NIFI-10992 - Option to build all include-x profiles
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on PR #6797:
URL: https://github.com/apache/nifi/pull/6797#issuecomment-1397578647
Added a couple of lines in the admin guide. Thanks for reviewing @ChrisSamo632 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6797: NIFI-10992 - Option to build all include-x profiles
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6797: NIFI-10992 - Option to build all include-x profiles
URL: https://github.com/apache/nifi/pull/6797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6797: NIFI-10992 - Option to build all include-x profiles
Posted by GitBox <gi...@apache.org>.
ChrisSamo632 commented on code in PR #6797:
URL: https://github.com/apache/nifi/pull/6797#discussion_r1059090649
##########
nifi-assembly/pom.xml:
##########
@@ -983,6 +983,9 @@ language governing permissions and limitations under the License. -->
<id>include-graph</id>
<activation>
<activeByDefault>false</activeByDefault>
+ <property>
+ <name>allProfiles</name>
Review Comment:
Could `allProfiles` be set as a property as part of a new profile, e.g. a profile called `include-all` that just contains a
```xml
<properties>
<allProfiles>true</allProfiles>
</properties>
```
Block? That way we can still use the `mvn -p` profile flag instead of `-D` setting, which may be a bit more obvious for people
I haven't tried this though so don't know whether the profiles dependency/linking would work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on pull request #6797: NIFI-10992 - Option to build all include-x profiles
Posted by GitBox <gi...@apache.org>.
ChrisSamo632 commented on PR #6797:
URL: https://github.com/apache/nifi/pull/6797#issuecomment-1382890994
> Thanks @ChrisSamo632 for the feedback, this is a fair point. I adjusted the PR to have an `include-all` profile.
Thanks @pvillard31, a `mvn` build with `-P include-all` did indeed seem to include the extra modules 👍
Just the documentation update that I think would be worthwhile to add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6797: NIFI-10992 - Option to build all include-x profiles
Posted by GitBox <gi...@apache.org>.
ChrisSamo632 commented on code in PR #6797:
URL: https://github.com/apache/nifi/pull/6797#discussion_r1059090649
##########
nifi-assembly/pom.xml:
##########
@@ -983,6 +983,9 @@ language governing permissions and limitations under the License. -->
<id>include-graph</id>
<activation>
<activeByDefault>false</activeByDefault>
+ <property>
+ <name>allProfiles</name>
Review Comment:
Could `allProfiles` be set as a peppery as part of a new profile, e.g. a profile called `include-all` that just contains a
```xml
<properties>
<allProfiles>true</allProfiles>
</properties>
```
Block? That way we can still use the `mvn -p` profile flag instead of `-D` setting, which may be a bit more obvious for people
I haven't tried this though so don't know whether the profiles dependency/linking would work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org