You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/10/01 21:37:16 UTC

[GitHub] [commons-imaging] kinow commented on a diff in pull request #254: [IMAGING-339] Basic WebP Support

kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342191274


##########
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##########
@@ -42,76 +44,105 @@
  * }</pre>
  *
  * @see <a href="https://developers.google.com/speed/webp/docs/riff_container#extended_file_format">Extended File Format</a>
- *
  * @since 1.0-alpha4
  */
-public final class WebPChunkVP8X extends WebPChunk {
-    private final boolean hasICC;
-    private final boolean hasAlpha;
-    private final boolean hasExif;
-    private final boolean hasXmp;
-    private final boolean isAnimation;
+public final class WebPChunkVp8x extends WebPChunk {
+    private final boolean icc;

Review Comment:
   No strong opinion here, let me revert it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org