You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/09 19:15:50 UTC
[GitHub] [iceberg] kbendick commented on pull request #2595: [SPARK] Allow existing spark2 JMH benchmarks to work with either spark 2 or spark 3
kbendick commented on pull request #2595:
URL: https://github.com/apache/iceberg/pull/2595#issuecomment-858022876
> @kbendick got this error
>
> ```
> Execution failed for task ':iceberg-spark2:jmh'.
> > A failure occurred while executing me.champeau.gradle.IsolatedRunner
> > Error during execution of benchmarks
> ```
>
> When i ran
> `g jmh`
>
> on the pr
So just like the current set up (as far as I'm aware), you have to specify the actual test to be run. So something like the following, as mentioned in the existing code [here](https://github.com/apache/iceberg/pull/2595/files#diff-ed844daf9dae5835b7ed247c21439af720df778c28596c644a9da8d7013f4fb9L56-L58)
```
./gradlew :iceberg-spark2:jmh \
-PjmhIncludeRegex=SparkParquetWritersNestedDataBenchmark \
-PjmhOutputPath=benchmark/spark-parquet-writers-nested-data-benchmark-result.txt
```
I will test simply `./gradlew jmh` on the current state of master vs my PR, but with my PR, the tests run the same way as mentioned in the doc comments of each test. @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org