You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/01/23 07:14:56 UTC
Review Request 69814: Improved the default actions of the mock CSI
plugin.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69814/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9517
https://issues.apache.org/jira/browse/MESOS-9517
Repository: mesos
Description
-------
This patch removes the macros used to generate the default actions for
the mock CSI plugin, and makes it returns all possible capabilities by
default so it can be used to test SLRP w/ a proxy-mode test CSI plugin.
Diffs
-----
src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9
src/tests/mock_csi_plugin.cpp 17c63358e78aad7e79b47d470ac9a94cf12ff9a7
Diff: https://reviews.apache.org/r/69814/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69814: Improved the default actions of the mock CSI
plugin.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69814/
-----------------------------------------------------------
(Updated Jan. 26, 2019, 12:31 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comment.
Bugs: MESOS-9517
https://issues.apache.org/jira/browse/MESOS-9517
Repository: mesos
Description
-------
This patch removes the macros used to generate the default actions for
the mock CSI plugin, and makes it returns all possible capabilities by
default so it can be used to test SLRP w/ a proxy-mode test CSI plugin.
Diffs (updated)
-----
src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9
src/tests/mock_csi_plugin.cpp 17c63358e78aad7e79b47d470ac9a94cf12ff9a7
Diff: https://reviews.apache.org/r/69814/diff/2/
Changes: https://reviews.apache.org/r/69814/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69814: Improved the default actions of the mock CSI
plugin.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69814/#review212332
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/mock_csi_plugin.cpp
Lines 88 (patched)
<https://reviews.apache.org/r/69814/#comment298094>
Could you add a comment here reproducing what is already in the commit message?
- Benjamin Bannier
On Jan. 23, 2019, 8:14 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69814/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 8:14 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9517
> https://issues.apache.org/jira/browse/MESOS-9517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes the macros used to generate the default actions for
> the mock CSI plugin, and makes it returns all possible capabilities by
> default so it can be used to test SLRP w/ a proxy-mode test CSI plugin.
>
>
> Diffs
> -----
>
> src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9
> src/tests/mock_csi_plugin.cpp 17c63358e78aad7e79b47d470ac9a94cf12ff9a7
>
>
> Diff: https://reviews.apache.org/r/69814/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>