[GitHub] [spark] HyukjinKwon commented on a change in pull request #33356: [SPARK-36146][PYTHON][INFRA][TEST] Upgrade Python version from 3.6 to higher version in GitHub linter

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33356:
URL: https://github.com/apache/spark/pull/33356#discussion_r670199996



##########
File path: python/pyspark/mllib/classification.pyi
##########
@@ -90,7 +90,7 @@ class LogisticRegressionWithLBFGS:
 
 class SVMModel(LinearClassificationModel):
     def __init__(self, weights: Vector, intercept: float) -> None: ...
-    @overload
+    @overload  # type: ignore
     def predict(self, x: VectorLike) -> float64: ...

Review comment:
       I can't follow why it complains:
   
   ```
   python/pyspark/mllib/classification.pyi:93: error: Signature of "predict" incompatible with supertype "LinearClassificationModel"
   ```
   
   Presumably because of different variable name? we can't change for compatibility reason.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org