You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/20 22:15:19 UTC

[GitHub] [tvm] Lunderberg opened a new pull request #8098: [Vulkan][Codegen] Added spvValidate check after vulkan shader generation

Lunderberg opened a new pull request #8098:
URL: https://github.com/apache/tvm/pull/8098


   spvValidate found the bug that was fixed in #7966, along with a few
   other issues on missing capability/extension declarations.  Now that
   all unit tests checked by the CI pass with it enabled, would like to
   enable by default.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] Lunderberg commented on pull request #8098: [Vulkan][Codegen] Added spvValidate check after vulkan shader generation

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8098:
URL: https://github.com/apache/tvm/pull/8098#issuecomment-845516473


   Potential reviewer: @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi merged pull request #8098: [Vulkan][Codegen] Added spvValidate check after vulkan shader generation

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8098:
URL: https://github.com/apache/tvm/pull/8098


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #8098: [Vulkan][Codegen] Added spvValidate check after vulkan shader generation

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8098:
URL: https://github.com/apache/tvm/pull/8098#issuecomment-845650817


   Thanks @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org