You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by John Sichi <js...@fb.com> on 2010/12/21 00:48:32 UTC
Review Request: HIVE-1856
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/188/
-----------------------------------------------------------
Review request for hive.
Summary
-------
review by JVS
This addresses bug HIVE-1856.
https://issues.apache.org/jira/browse/HIVE-1856
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2508f2b
conf/hive-default.xml fdc9a82
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java cbd9d62
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 6b47702
ql/src/test/queries/clientnegative/drop_table_failure1.q PRE-CREATION
ql/src/test/queries/clientnegative/drop_table_failure2.q PRE-CREATION
ql/src/test/queries/clientnegative/drop_view_failure2.q e8e78a3
ql/src/test/queries/clientpositive/drop_table.q PRE-CREATION
ql/src/test/queries/clientpositive/drop_view.q PRE-CREATION
ql/src/test/results/clientnegative/drop_table_failure1.q.out PRE-CREATION
ql/src/test/results/clientnegative/drop_table_failure2.q.out PRE-CREATION
ql/src/test/results/clientnegative/drop_view_failure2.q.out 80903f9
ql/src/test/results/clientpositive/drop_table.q.out PRE-CREATION
ql/src/test/results/clientpositive/drop_view.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/188/diff
Testing
-------
Thanks,
John
Re: Review Request: HIVE-1856
Posted by Marcel Kornacker <ma...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/188/#review78
-----------------------------------------------------------
Hi John, I created HIVE-1858 as a follow-on to HIVE-1856, to track DROP IF EXISTS for partitions, indices and temp. functions.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/188/#comment118>
Done.
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/188/#comment119>
Done.
- Marcel
On 2010-12-20 15:48:32, John Sichi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/188/
> -----------------------------------------------------------
>
> (Updated 2010-12-20 15:48:32)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> review by JVS
>
>
> This addresses bug HIVE-1856.
> https://issues.apache.org/jira/browse/HIVE-1856
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2508f2b
> conf/hive-default.xml fdc9a82
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java cbd9d62
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 6b47702
> ql/src/test/queries/clientnegative/drop_table_failure1.q PRE-CREATION
> ql/src/test/queries/clientnegative/drop_table_failure2.q PRE-CREATION
> ql/src/test/queries/clientnegative/drop_view_failure2.q e8e78a3
> ql/src/test/queries/clientpositive/drop_table.q PRE-CREATION
> ql/src/test/queries/clientpositive/drop_view.q PRE-CREATION
> ql/src/test/results/clientnegative/drop_table_failure1.q.out PRE-CREATION
> ql/src/test/results/clientnegative/drop_table_failure2.q.out PRE-CREATION
> ql/src/test/results/clientnegative/drop_view_failure2.q.out 80903f9
> ql/src/test/results/clientpositive/drop_table.q.out PRE-CREATION
> ql/src/test/results/clientpositive/drop_view.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/188/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> John
>
>