serializer-common and JSON

[Guillaume Smet <gu...@gmail.com>]

Hi !

We are working on the serializer projects of Wicketstuff with several
goals in mind:
1/ update the FAST dependency of the current project to the latest 1.x
2/ create a FAST2 serializer as FAST2 is a bit different and it might
still be a better idea to use 1.x for some use cases;
3/ improve the reporting of the serializer-common stuff.

For 1 and 2, we are working with Rüdiger, the FAST developer to fix a
few bugs and reintroduce some stuff needed by 3/. It's in good shape
(most PR accepted, 2 PR pending).

For 3/, we are working on the D3.js part and we would like to remove
the ugly JSON generator, which does not escape the values and is not
very reliable.

We have several solutions in mind:
1/ add a dependency to wicket-core to this module as wicket-core has
the JSON.org classes already imported
2/ import the needed JSON.org classes in the project as done in wicket-core
3/ use Jackson -> this is the library we use for JSON but I don't
think it's a very good idea in this case as it introduces a big
dependency for a very small need.

So we hesitate between 1/ and 2/ and would like your advice.

Note that the value of this inspection code for serialization is
really really underestimated: we improved a *lot* the performances of
one of our application since we started to inspect what is really
serialized in our pages and we fixed a few things.

We are still contemplating moving to FAST *but* even if we stay with
the default Java serializer, using FAST and this inspection code to
understand what is serialized is really nice.

This is also a heads up that we are working on this so that we don't
do the work twice. Expect a pull request for this in the next 2 weeks.

Thanks for your feedback.

Re: serializer-common and JSON

[Martin Grigorov <mg...@apache.org>]

Thanks Guillaume !
I'll review the Pull Request soon !

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sat, Oct 25, 2014 at 8:57 PM, Guillaume Smet <gu...@gmail.com>
wrote:

> Hi Martin,
>
> It took me far more time than expected but I pushed a first PR to
> wicketstuff with updates to Fast 1 module and a new Fast 2 module.
>
> My next step is to work on what my coworker Sébastien Dot modified in
> serializer-common to provide more analyzing tools. FYI, we followed
> your suggestions to include a wicket-core dependency to provide the
> JSON machinery to the module.
>
> --
> Guillaume
>

Re: serializer-common and JSON

[Guillaume Smet <gu...@gmail.com>]

Hi Martin,

It took me far more time than expected but I pushed a first PR to
wicketstuff with updates to Fast 1 module and a new Fast 2 module.

My next step is to work on what my coworker Sébastien Dot modified in
serializer-common to provide more analyzing tools. FYI, we followed
your suggestions to include a wicket-core dependency to provide the
JSON machinery to the module.

-- 
Guillaume

Re: serializer-common and JSON

[Martin Grigorov <mg...@apache.org>]

Hi,

On Wed, Oct 1, 2014 at 3:04 PM, Guillaume Smet <gu...@gmail.com>
wrote:

> Hi !
>
> We are working on the serializer projects of Wicketstuff with several
> goals in mind:
> 1/ update the FAST dependency of the current project to the latest 1.x
> 2/ create a FAST2 serializer as FAST2 is a bit different and it might
> still be a better idea to use 1.x for some use cases;
> 3/ improve the reporting of the serializer-common stuff.
>
> For 1 and 2, we are working with Rüdiger, the FAST developer to fix a
> few bugs and reintroduce some stuff needed by 3/. It's in good shape
> (most PR accepted, 2 PR pending).
>

Great !!!


>
> For 3/, we are working on the D3.js part and we would like to remove
> the ugly JSON generator, which does not escape the values and is not
> very reliable.
>
> We have several solutions in mind:
> 1/ add a dependency to wicket-core to this module as wicket-core has
> the JSON.org classes already imported
> 2/ import the needed JSON.org classes in the project as done in wicket-core
> 3/ use Jackson -> this is the library we use for JSON but I don't
> think it's a very good idea in this case as it introduces a big
> dependency for a very small need.
>
> So we hesitate between 1/ and 2/ and would like your advice.
>

My vote is for 1).
I doubt the project is used for anything non-Wicket related.
(Even if it is then they better start use Wicket now! :-) )


>
> Note that the value of this inspection code for serialization is
> really really underestimated: we improved a *lot* the performances of
> one of our application since we started to inspect what is really
> serialized in our pages and we fixed a few things.
>
> We are still contemplating moving to FAST *but* even if we stay with
> the default Java serializer, using FAST and this inspection code to
> understand what is serialized is really nice.
>
> This is also a heads up that we are working on this so that we don't
> do the work twice. Expect a pull request for this in the next 2 weeks.
>
> Thanks for your feedback.
>