You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by ma...@apache.org on 2010/07/24 10:54:43 UTC
svn commit: r978831 - in /jakarta/bcel/trunk/src/main/java/org/apache/bcel:
generic/LDC.java generic/PUSH.java util/BCELFactory.java
Author: markt
Date: Sat Jul 24 08:54:43 2010
New Revision: 978831
URL: http://svn.apache.org/viewvc?rev=978831&view=rev
Log:
Fix Gump nags
The pom declares the source as 1.4 so annotations can't be used
Also change some insterted tabs back to 4 spaces
No functional change
Modified:
jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/LDC.java
jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/PUSH.java
jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/BCELFactory.java
Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/LDC.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/LDC.java?rev=978831&r1=978830&r2=978831&view=diff
==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/LDC.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/LDC.java Sat Jul 24 08:54:43 2010
@@ -63,8 +63,7 @@ public class LDC extends CPInstruction i
* Dump instruction as byte code to stream out.
* @param out Output stream
*/
- @Override
- public void dump( DataOutputStream out ) throws IOException {
+ public void dump( DataOutputStream out ) throws IOException {
out.writeByte(opcode);
if (length == 2) {
out.writeByte(index);
@@ -77,8 +76,7 @@ public class LDC extends CPInstruction i
/**
* Set the index to constant pool and adjust size.
*/
- @Override
- public final void setIndex( int index ) {
+ public final void setIndex( int index ) {
super.setIndex(index);
setSize();
}
@@ -87,8 +85,7 @@ public class LDC extends CPInstruction i
/**
* Read needed data (e.g. index) from file.
*/
- @Override
- protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException {
+ protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException {
length = 2;
index = bytes.readUnsignedByte();
}
@@ -115,8 +112,7 @@ public class LDC extends CPInstruction i
}
- @Override
- public Type getType( ConstantPoolGen cpg ) {
+ public Type getType( ConstantPoolGen cpg ) {
switch (cpg.getConstantPool().getConstant(index).getTag()) {
case org.apache.bcel.Constants.CONSTANT_String:
return Type.STRING;
@@ -145,8 +141,7 @@ public class LDC extends CPInstruction i
*
* @param v Visitor object
*/
- @Override
- public void accept( Visitor v ) {
+ public void accept( Visitor v ) {
v.visitStackProducer(this);
v.visitPushInstruction(this);
v.visitExceptionThrower(this);
Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/PUSH.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/PUSH.java?rev=978831&r1=978830&r2=978831&view=diff
==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/PUSH.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/PUSH.java Sat Jul 24 08:54:43 2010
@@ -185,8 +185,7 @@ public final class PUSH implements Compo
/**
* @return mnemonic for instruction
*/
- @Override
- public String toString() {
+ public String toString() {
return instruction.toString() + " (PUSH)";
}
}
Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/BCELFactory.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/BCELFactory.java?rev=978831&r1=978830&r2=978831&view=diff
==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/BCELFactory.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/BCELFactory.java Sat Jul 24 08:54:43 2010
@@ -120,8 +120,7 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitLocalVariableInstruction( LocalVariableInstruction i ) {
+ public void visitLocalVariableInstruction( LocalVariableInstruction i ) {
short opcode = i.getOpcode();
Type type = i.getType(_cp);
if (opcode == Constants.IINC) {
@@ -135,8 +134,7 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitArrayInstruction( ArrayInstruction i ) {
+ public void visitArrayInstruction( ArrayInstruction i ) {
short opcode = i.getOpcode();
Type type = i.getType(_cp);
String kind = (opcode < Constants.IASTORE) ? "Load" : "Store";
@@ -145,8 +143,7 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitFieldInstruction( FieldInstruction i ) {
+ public void visitFieldInstruction( FieldInstruction i ) {
short opcode = i.getOpcode();
String class_name = i.getClassName(_cp);
String field_name = i.getFieldName(_cp);
@@ -157,8 +154,7 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitInvokeInstruction( InvokeInstruction i ) {
+ public void visitInvokeInstruction( InvokeInstruction i ) {
short opcode = i.getOpcode();
String class_name = i.getClassName(_cp);
String method_name = i.getMethodName(_cp);
@@ -171,8 +167,7 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitAllocationInstruction( AllocationInstruction i ) {
+ public void visitAllocationInstruction( AllocationInstruction i ) {
Type type;
if (i instanceof CPInstruction) {
type = ((CPInstruction) i).getType(_cp);
@@ -222,40 +217,34 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitLDC( LDC i ) {
+ public void visitLDC( LDC i ) {
createConstant(i.getValue(_cp));
}
- @Override
- public void visitLDC2_W( LDC2_W i ) {
+ public void visitLDC2_W( LDC2_W i ) {
createConstant(i.getValue(_cp));
}
- @Override
- public void visitConstantPushInstruction( ConstantPushInstruction i ) {
+ public void visitConstantPushInstruction( ConstantPushInstruction i ) {
createConstant(i.getValue());
}
- @Override
- public void visitINSTANCEOF( INSTANCEOF i ) {
+ public void visitINSTANCEOF( INSTANCEOF i ) {
Type type = i.getType(_cp);
_out.println("il.append(new INSTANCEOF(_cp.addClass(" + BCELifier.printType(type) + ")));");
}
- @Override
- public void visitCHECKCAST( CHECKCAST i ) {
+ public void visitCHECKCAST( CHECKCAST i ) {
Type type = i.getType(_cp);
_out.println("il.append(_factory.createCheckCast(" + BCELifier.printType(type) + "));");
}
- @Override
- public void visitReturnInstruction( ReturnInstruction i ) {
+ public void visitReturnInstruction( ReturnInstruction i ) {
Type type = i.getType(_cp);
_out.println("il.append(_factory.createReturn(" + BCELifier.printType(type) + "));");
}
@@ -264,8 +253,7 @@ class BCELFactory extends EmptyVisitor {
private final List branches = new ArrayList();
- @Override
- public void visitBranchInstruction( BranchInstruction bi ) {
+ public void visitBranchInstruction( BranchInstruction bi ) {
BranchHandle bh = (BranchHandle) branch_map.get(bi);
int pos = bh.getPosition();
String name = bi.getName() + "_" + pos;
@@ -311,8 +299,7 @@ class BCELFactory extends EmptyVisitor {
}
- @Override
- public void visitRET( RET i ) {
+ public void visitRET( RET i ) {
_out.println("il.append(new RET(" + i.getIndex() + ")));");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org